Re: [PATCH v2] efi: Enable EFI_SET_VIRTUAL_ADDRESS_MAP by default

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Mar 17, 2026 at 02:33:34PM +0000, Teddy Astie wrote:
> Many machines fails to boot if this option is disabled.
> It's off by default as it was deemed too risky for being enabled
> by default late in the Xen 4.13 cycle, but found out to be safe.
> As there are no known drawback by having this option on, enable
> it by default.
> 
> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>

I think this is enough for this change to go in. If somebody wants to do
more archaeology, mailing list archives exist, there is no point in
summarizing it all here.

Acked-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

> ---
> v2:
>  - review commit description
>  - drop "If unsure" note
> 
>  xen/common/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index d7e79e752a..0a20aa0a12 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -363,14 +363,13 @@ config KEXEC
>  
>  config EFI_SET_VIRTUAL_ADDRESS_MAP
>      bool "EFI: call SetVirtualAddressMap()" if EXPERT
> +    default y
>      help
>        Call EFI SetVirtualAddressMap() runtime service to setup memory map for
>        further runtime services. According to UEFI spec, it isn't strictly
>        necessary, but many UEFI implementations misbehave when this call is
>        missing.
>  
> -      If unsure, say N.
> -
>  config XSM
>       bool "Xen Security Modules support"
>       default ARM
> -- 
> 2.53.0
> 
> 
> 
> --
> Teddy Astie | Vates XCP-ng Developer
> 
> XCP-ng & Xen Orchestra - Vates solutions
> 
> web: https://vates.tech
> 
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature