[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v3 2/3] x86/acpi: Integrate BGRT preservation with status reporting


  • To: Soumyajyotii Ssarkar <soumyajyotisarkar23@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, sarkarsoumyajyoti23@xxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 17 Mar 2026 13:46:48 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuNjVif0kI6xoqMZ8+Ck7gPk3cNBabG+q045428FfXE=; b=lEdDnvnmxBheqf4Aa1no8DNWZ7MrDnO2oR7u2l+6/Qn3XOvzkdXc/a7Tj/It3cwR5KpU7bVdZNNgKT5ncQR9PH/PFVkzI2sWbIO3jhEPlvb14zyIjOqWaYg43XN6o0QBTaJwRegEBSvNmGv0BoWOFxXsU6lXSXnR1o06prLgVQNLCgdNFyJARv6O750wLn3NbKzVAvgyECNuESMMgjZOT2UnAKaMhgCF+bNTPWz0LXGkDy/jvDsdp1Yo9AQZy1YV6C9Yk1YdQvie85TXpurwSE5bPiJLDzEll9ZM7XZdLo9rh9cbBooL6zaXgmeTQEV8vHnw5qdqYNOIk6W0tsB+Vw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CBe24odqEaTA707Bbu6Tqdm7lIv/rmLewo1AcAi+BY5vfpJQ48DE4uL0lgvA84vpZCfk/M2hpJRWtYbuRbu3tH3n7tI6lqpdw6EBMzrRQ1tKCAdlPYa4rvAA80ZeoZ7qjKeXXxd94Pml6mtqTxWAmoxs1tDjmXaMSZztCVCbyWYaSi+6b5fjKz5yueJCYCVOM4TiYfNuJCe3GE80qwTnImLW8KIjEme7CBr/RGAYALUaxaAuRfkkIVjvASJuDk2QvUaukdX+fbIcVWugbuEHtJTO1mHfepKqDKg1H6QmkebjqKSrzEZ3PrpT7D2x8YJHYKXYYk9RisvaOTnmrVvsrw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Mar 2026 13:47:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12/03/2026 11:14 am, Soumyajyotii Ssarkar wrote:
> diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
> index 1ca2360e00..20afe79db9 100644
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
>  static int __init cf_check acpi_invalidate_bgrt(struct acpi_table_header 
> *table)
>  {
>       struct acpi_table_bgrt *bgrt_tbl =
> @@ -754,5 +760,7 @@ int __init acpi_boot_init(void)
>
>       acpi_table_parse(ACPI_SIG_BGRT, acpi_invalidate_bgrt);
>
> +     efi_bgrt_status_info();

To help with your build failure, given this call from outside EFI code,
you need...

> +
>       return 0;
>  }
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index e6451130ce..68e06d707c 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1911,6 +1911,22 @@ static bool __init cf_check rt_range_valid(unsigned 
> long smfn, unsigned long emf
>      return true;
>  }
>
> +void __init efi_bgrt_status_info(void)
> +{
> +    if ( !efi_enabled(EFI_BOOT) )
> +        return;
> +
> +    if ( bgrt_info.preserved )
> +    {
> +        printk(XENLOG_INFO "EFI: BGRT image preserved: %lu KB\n",
> +               bgrt_info.size / 1024);
> +        printk(XENLOG_INFO "EFI: BGRT relocated from %p to %p\n",
> +               bgrt_info.old_addr, bgrt_info.new_addr);
> +    }
> +    else if ( bgrt_info.failure_reason[0] )
> +        printk(XENLOG_WARNING "EFI: BGRT preservation failed: %s\n",
> +               bgrt_info.failure_reason);
> +}

... a matching stub function in xen/common/efi/common-stub.c

xen.efi is constructed by taking non-efi Xen and linking in a few more
object files.  It is not a full rebuild with different toolchain settings.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.