[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/8] vpci: Use pervcpu ranges for BAR mapping
- To: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Mon, 16 Mar 2026 20:36:06 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XUMtEea3a+YnlF3/9rKfmZaz3dVFSAle/v99I03LFEc=; b=lcU7d16XZdkj0Jl1ERGegzK8+JxPjul3q7Y36rjK3odRtFqaXXVtMEyVXbZUODwCKGHbpwMrCU79CwCEnjHOP0dmCfSdyb7TnVEF12vkUA1QJ0EZZAg9LfP+udG7DrgcEwYDT49U8yP18KdSEWkhiie9vSp05FjmuDngEzfkj1NGwmiTpTMtceDO/hldZ4o6KBSy0pkPe2QdIl7vhBIa+W7MszeSpVvy3Ev0t+28URk8Y1Z4oHU0uSelUiABpxMIpTbQNf7yNLJEzFpvWJxr9z0hLau6G0yoTicIFf3KLMzHH6xpzdV22x6VA3nISxFJH4U9EK/5zNJw4X1wcH/tbw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rRHwIB+4hj+ZDL+mf5Aew1jKIJSSi7mTSYqGvBzMd66ZAG3VnoB+Z/tOVhd4K1IPhFpPCfE7hKtRTqlE9xqXFe9altCU4aoBf8wm5jHCp8T3uS+uUmKwmgMEzP5ZYifH6Se7VxC7V7mK/zsrpSc22mJgHAcDhENPOtlHcGqMas/2pv0DBeS1q1MmXK/5nMHYa6ppV0szYL2TSI2A7+DGZ2Vmk9StX1/rEIIYRO6L3Q+uGLIsmpP5rCUbxQOMMD2bk7jusEq55Va4oUUhmuDX+LpkC+lCl/JaqL67tk3Qe0sbTLUZ9Wh5Wp7C8BULCSZVqUVaxLdAYx/AZiyhW1zaow==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 17 Mar 2026 00:36:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/9/26 07:08, Mykyta Poturai wrote:
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 07ec991a12..cb64d9b9fc 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
... snip ...
> @@ -330,12 +332,13 @@ int vpci_modify_bars(const struct pci_dev *pdev,
> uint16_t cmd, bool rom_only)
> for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> {
> struct vpci_bar *bar = &header->bars[i];
> + struct rangeset *mem = current->vpci.bar_mem[i];
> unsigned long start = PFN_DOWN(bar->addr);
> unsigned long end = PFN_DOWN(bar->addr + bar->size - 1);
> unsigned long start_guest = PFN_DOWN(bar->guest_addr);
> unsigned long end_guest = PFN_DOWN(bar->guest_addr + bar->size - 1);
>
> - if ( !bar->mem )
> + if ( !mem )
Since all the members of the bar_mem array are allocated unconditionally in
vcpu_create, is the check here still necessary?
|
