[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] arm/pci: address violations of MISRA C Rule 20.7


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Fri, 13 Mar 2026 11:44:17 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qrKVILKrNRmJjdA+LChhKJaM/U+KPX5v9tqb88jBfxw=; b=sgO1JI0U9mgT9sAJ66et/CujC3gVVvkh23Bd7jm96yGkavo9z7+L0z/j3J7aTW3M9l6cPbm5NDkPnDzz16Q4kGwfLPcFkIFSXJ4yT5lTXgTcCR3bNAUWtiG1TiyFuhjbeWeQya8UT4TZkd/MhFVTcD8B4AxNQ0Fs+Ft2WW9Dq/pr2kCQo6PZXjDmSAou/9P0q3tLpyABaoQEpphceR5syZqKQkQr2nJta6BLpq5wFrLrg8ixN8wW+vGooIgWOYhEBT/MoE4uCg2MqDaRDfPMWmAJTrzvLzdk8Ej4jZiHgi97zFTxFCPm1YkFBQqlEUko5knOdd85RI/GwyLZNEAGuQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ArIJI9AR0YpY+YcJY+h/pI0RZvU8qv3/9/neYoTfl2ENb+7V9TDlZplhFKx3p7u8991VqCRqcccv9q0zKu0GasIfOiYAdR82qZaZIPm2plrFxoAo8lG3gYr7fnkXK34yqcFxJjfdMLtaKQVzHCoSQCtJ+ve315wgf80N0P5skvy9+HDhRHt8Lc3whOVK49G+wfn6xnkC0YrGAvamn0qAzitzL3NHSSa8CClNIhB09HSbDV2XWpvbIoeTQeR8uORuBNUZOsAIgFV4qb3/bMXcliRB3DQXvfLUnOogeeM3z8SdiY9FfgJnfzL1NxBUU0m0UuyRN2o6jlmQJ40vebwDQg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 13 Mar 2026 11:44:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcst65V5mePVDA4kuP+Yr3akM65g==
  • Thread-topic: [PATCH 1/2] arm/pci: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses".

In macros PCI_ERR_VALUE(), PCI_OP_WRITE() and PCI_OP_READ() add the
parentheses around the macro's parameter to prevent against unintended
expansions.

No functional changes.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
 xen/arch/arm/pci/pci-access.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c
index 2b23d552bb..7074fd9c09 100644
--- a/xen/arch/arm/pci/pci-access.c
+++ b/xen/arch/arm/pci/pci-access.c
@@ -16,7 +16,7 @@
 #include <asm/io.h>
 
 #define INVALID_VALUE (~0U)
-#define PCI_ERR_VALUE(len) GENMASK(0, len * 8)
+#define PCI_ERR_VALUE(len) GENMASK(0, (len) * 8)
 
 static const struct pci_ops *get_ops(struct pci_host_bridge *bridge,
                                      pci_sbdf_t sbdf)
@@ -139,14 +139,14 @@ static void pci_config_write(pci_sbdf_t sbdf, unsigned 
int reg,
     void pci_conf_write##size(pci_sbdf_t sbdf,              \
                               unsigned int reg, type data)  \
 {                                                           \
-    pci_config_write(sbdf, reg, size / 8, data);            \
+    pci_config_write(sbdf, reg, (size) / 8, data);            \
 }
 
 #define PCI_OP_READ(size, type)                             \
     type pci_conf_read##size(pci_sbdf_t sbdf,               \
                               unsigned int reg)             \
 {                                                           \
-    return pci_config_read(sbdf, reg, size / 8);            \
+    return pci_config_read(sbdf, reg, (size) / 8);            \
 }
 
 PCI_OP_READ(8, uint8_t)
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.