[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/3] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_uid() on non-x86
- To: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
- From: fengchengwen <fengchengwen@xxxxxxxxxx>
- Date: Fri, 13 Mar 2026 10:30:16 +0800
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Paul Walmsley <pjw@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Alexandre Ghiti <alex@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Kees Cook <kees@xxxxxxxxxx>, Yanteng Si <si.yanteng@xxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Kai Huang <kai.huang@xxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Thorsten Blum <thorsten.blum@xxxxxxxxx>, Kevin Loughlin <kevinloughlin@xxxxxxxxxx>, Zheyun Shen <szy0127@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>, Xin Li <xin@xxxxxxxxx>, "Ahmed S . Darwish" <darwi@xxxxxxxxxxxxx>, Sohil Mehta <sohil.mehta@xxxxxxxxx>, Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, James Clark <james.clark@xxxxxxxxxx>, Besar Wicaksono <bwicaksono@xxxxxxxxxx>, Ma Ke <make24@xxxxxxxxxxx>, Wei Huang <wei.huang2@xxxxxxx>, Andy Gospodarek <andrew.gospodarek@xxxxxxxxxxxx>, Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>, <punit.agrawal@xxxxxxxxxxxxxxxx>, <guohanjun@xxxxxxxxxx>, <suzuki.poulose@xxxxxxx>, <ryan.roberts@xxxxxxx>, <chenl311@xxxxxxxxxxxxxxx>, <masahiroy@xxxxxxxxxx>, <wangyuquan1236@xxxxxxxxxxxxxx>, <anshuman.khandual@xxxxxxx>, <heinrich.schuchardt@xxxxxxxxxxxxx>, <Eric.VanTassell@xxxxxxx>, <wangzhou1@xxxxxxxxxxxxx>, <wanghuiqiang@xxxxxxxxxx>, <liuyonglong@xxxxxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <loongarch@xxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, <linux-perf-users@xxxxxxxxxxxxxxx>, <stable@xxxxxxxxxxxxxxx>
- Delivery-date: Fri, 13 Mar 2026 02:30:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/12/2026 7:07 PM, Jonathan Cameron wrote:
> On Thu, 12 Mar 2026 15:23:14 +0800
> Chengwen Feng <fengchengwen@xxxxxxxxxx> wrote:
>
>> To unify the CPU ACPI ID retrieval interface across architectures,
>> rename the existing get_acpi_id_for_cpu() function to
>> acpi_get_cpu_uid() on arm64/riscv/loongarch platforms.
>>
>> This is a pure rename with no functional change, preparing for a
>
> It's not just a rename. This should mention that the addition of error
> checks and hence the resulting signature change.
Sorry for overlooking this, it has already been fixed in v7.
And v7 also fix below review comments.
Thanks
>
>> consistent ACPI Processor UID retrieval interface across all ACPI-enabled
>> platforms.
>>
>> Note: Move the ARM64-specific get_cpu_for_acpi_id() implementation to
>> arch/arm64/kernel/acpi_numa.c to fix compilation errors from
>> circular header dependencies introduced by the rename.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Chengwen Feng <fengchengwen@xxxxxxxxxx>
>> Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
> From a reread, a few minor style consistency things inline.
>
...
>
|