[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v v2 7/7] x86: relax some CPU checks for non-64 bit CPUs


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
  • Date: Thu, 12 Mar 2026 20:43:39 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkexYGptCHbgLndtPlhEQnAVvgf8/mTkKb/te38N9IQ=; b=gFAxtI7kWRhoLvKn69JokvtWXRdTugfINxrGGYZo1EbIO1ZOiO6MviNYoOTELLNKdTWpsnQLhZXyglnFPEx7LIuufuO0Ypsd2LaZf8DdlzmSAqNV0NLkVGEHGITloyYPdpMBhwUqr7uU0gJmOgiqO2gNgEwQ4zDgbEacaTj2tDAtkmc1BexP6OK5gKprSqJvgv33n4PB3yYSYwtQjyKDFg4obtwywLsZfcZg87rMNRuq3IaNcigiJ/nFfIwodvbyXKtrEFBBZJb4j7yCQwpENuw4jLynaK1c/8TUKLfNwWJvT7r99rGu4mGhbNUtWnQTv3i4VqztRHMnOXTKZtE6lQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jm1T4zb/POnqnOUD0H0yjBgtkrb0ewgECKYD5Ctn7e+ioCVZgij/DaEp97a0ikN/zCmdpFAgtkZTWALB6imv1aOlbZ5BS2h2zbZCeQxmket5qwwWFE8TwyyjhFW1jX+5QztFSWkgXJMdDpSVVlevVcIS/zHETDEKB4Dz3OWp3H9xbHwzDufNwt3ZY4iOTRHH+yhcerYmSwOleQwddRRXx17a3+V0oz7pLybq3p5Ws81YHYtmL8o0ZYyHk7JH6HdpFrF2YXmpwtp6RJ/NhYpBQ9Sa9zvOk59fbpWhPlc5C6I0cf8zO71JLg0L2iWJfGvIHIYUBBQrJ4sXPunqo765IQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: jbeulich@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Kevin Lampis <kevin.lampis@xxxxxxxxxx>
  • Delivery-date: Thu, 12 Mar 2026 20:47:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

These old non-64 bit CPU models are not supported by Xen anymore so the
checks are no longer needed.

Signed-off-by: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
---
Changes in v2:
- New patch based on review comments
---
 xen/arch/x86/acpi/cpu_idle.c    | 2 +-
 xen/arch/x86/cpu/mcheck/mce.c   | 8 +-------
 xen/arch/x86/cpu/mtrr/generic.c | 3 +--
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 6622965ace..640935c40c 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -1059,7 +1059,7 @@ static void acpi_processor_power_init_bm_check(struct 
acpi_processor_flags *flag
      * is not required while entering C3 type state on
      * P4, Core and beyond CPUs
      */
-    if ( c->vendor == X86_VENDOR_INTEL && c->vfm >= INTEL_CORE_YONAH )
+    if ( c->vendor == X86_VENDOR_INTEL )
             flags->bm_control = 0;
 }
 
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 8a41116aa4..9f45ca5be1 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -777,13 +777,7 @@ void mcheck_init(struct cpuinfo_x86 *c, bool bsp)
 
 #ifdef CONFIG_INTEL
     case X86_VENDOR_INTEL:
-        switch ( c->family )
-        {
-        case 6:
-        case 15:
-            inited = intel_mcheck_init(c, bsp);
-            break;
-        }
+        inited = intel_mcheck_init(c, bsp);
         break;
 #endif
 
diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 190be7f1b4..23c279eb9a 100644
--- a/xen/arch/x86/cpu/mtrr/generic.c
+++ b/xen/arch/x86/cpu/mtrr/generic.c
@@ -218,8 +218,7 @@ static void __init print_mtrr_state(const char *level)
                        printk("%s  %u disabled\n", level, i);
        }
 
-       if ((boot_cpu_data.vendor == X86_VENDOR_AMD &&
-            boot_cpu_data.family >= 0xf) ||
+       if (boot_cpu_data.vendor == X86_VENDOR_AMD ||
             boot_cpu_data.vendor == X86_VENDOR_HYGON) {
                uint64_t syscfg, tom2;
 
-- 
2.51.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.