[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests/pdx: fix overflow from conversion from page index to address on 32bit


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Thu, 12 Mar 2026 09:02:06 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=08wODLFuN4N6BksfeVKCpF7yEiF0rthYfncaPcd8r/w=; b=AacP6j9ATZxRSxe4EGn8sHFGdlCZ4dhcwt/f2SP9dl12K6t6hyQJkO/0GtSxXjxhFd7N3wasOhuEeon19V6svqmq/m5k4aBpp3eUAdvzIQZ7vfCgmYX4dm4uojr6zxRXUwsn62feZpWVSrecldHGkOJ/Hq45VuicXdLJK2gv5eAj2e3ORj7/FneeImVAMwvFFdL9O0dUZHIG1de/ghB9oAIcc1FKDl6h3BCO05HEo8Gp09RzLMqYX6x1ohVC4kQ+S0DSQLGeREhX8+4npTv1TCn0XdZKJNkDXJQnOTlhr9VMUUk/5p5gB1aCN1UgnIPtcsTKb3Qaf81JMQDcMaVPDA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dLpfT80wsMpI2ZkKgRCGaaiSG9IpJLTj9+EPDz5GjsnHdzdU4hmJyMQIAO9efT1eUyloLYz/PDV6b6Zieweakj/Gj3029GA3lDFcadlodIYU9FrKzTqQIksDctcOB1W58Mi8xIUm98B+VFltBxA9mt4X85ANEJAsKwfH9Iz0Yhh7sw/gcIhQTj3D8XRuw6yfoWCShxO98XGNByvigyW+WvGM1Oa8cuQCGlNh/55VwlD5zTabYyAymfyJEOu0+YMWoTqMyfHvx2mhFuyfKFXPxdYvYMraZ7U4aGdV6H5zjmxQlazWFIXZjYnD+cCxshWbUhxbkWDegn2qduyIa9RkGg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Edwin Török <edwin.torok@xxxxxxxxxx>
  • Delivery-date: Thu, 12 Mar 2026 08:02:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

When building the PDX test harness as a 32bit executable the page shifts
done on unsigned long types can overflow.  Instead use pfn_to_paddr(),
which casts the values to paddr_t previous to doing the shift.

Fixes: cb50e4033717 ("test/pdx: add PDX compression unit tests")
Reported-by: Edwin Török <edwin.torok@xxxxxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 tools/tests/pdx/test-pdx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/tests/pdx/test-pdx.c b/tools/tests/pdx/test-pdx.c
index eefd54c76815..066bd3e7e569 100644
--- a/tools/tests/pdx/test-pdx.c
+++ b/tools/tests/pdx/test-pdx.c
@@ -208,8 +208,8 @@ int main(int argc, char **argv)
             if ( !tests[i].ranges[j].start && !tests[i].ranges[j].end )
                 break;
 
-            pfn_pdx_add_region(tests[i].ranges[j].start << PAGE_SHIFT,
-                               size << PAGE_SHIFT);
+            pfn_pdx_add_region(pfn_to_paddr(tests[i].ranges[j].start),
+                               pfn_to_paddr(size));
         }
 
         if ( pfn_pdx_compression_setup(0) != tests[i].compress )
@@ -233,8 +233,8 @@ int main(int argc, char **argv)
             if ( !start && !end )
                 break;
 
-            if ( !pdx_is_region_compressible(start << PAGE_SHIFT, 1) ||
-                 !pdx_is_region_compressible((end - 1) << PAGE_SHIFT, 1) )
+            if ( !pdx_is_region_compressible(pfn_to_paddr(start), 1) ||
+                 !pdx_is_region_compressible(pfn_to_paddr(end - 1), 1) )
             {
                 printf(
     "PFN compression invalid, pages %#lx and %#lx should be compressible\n",
-- 
2.51.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.