[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] x86/hvm: Disable cross-vendor handling in #UD handler
- To: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 11 Mar 2026 18:48:20 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6NGDs+BRyn7XweAWMRpwVKPpBX19IbRMJ8dz2ljzaz4=; b=psMPgWnzyHD6hIWQiyhyt/nDG5JZuSW47mEtUKZbwzkJ/p+WPpgbs+k+PDjChmEErn6rQvyMg2iEPNhJFa6ca0kOBomy/jG5r49ZVRG+ORQQ7sSm9Zy/QGGd6+3L32/qSSO2Zkn9x4QZtzg3DsYWbGhnG890UJpOHNSbyMmW/gLU+dNMVzOg6BcQ7HPN3zfD+HeAuL41DOc/vKAPK2lGod84Eunst7oGA/UcVVIFH/NjKgdNgNA6VhQjA5Id5sj5I8Zh5e88yakcLUiRt/4Leq6IUsDM/7NuWJcNiDyAWv/x4dG+tQ8Xep2Q/tBnsKJAAbNe2DXva6JmduFoeocneA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iW6QCKyQPPl4wDwxqNkDR/tUqdnSfKa/mxraQ0uAYsllS4jTpDUph5uvHQixSdcHcU7X7EaotqeMm6f8x4kJgKOq+PcC3nIxJKfTYpk/JrJ3dI61a4aocfm09b8vwdMw4/KivuRlBafXIJf70sTRP7FT9YdrNpBl/77368SsKqh9QJs8+HHvxfiePhuX4Vl5efmbghJIdf4OUxPklSypoSouBz9EDlumdtxR9sUNmV4JshJ+4PezwpIfpHVHg4d16DkRoG3jGNPtiSea9LjXT6nGfroENDS6toNaAGztC6XYuXd2aIyLEWZtlmQTPr9zrd0moiC/dpQeQD2i82Skiw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>
- Delivery-date: Wed, 11 Mar 2026 18:48:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/03/2026 2:27 pm, Alejandro Vallejo wrote:
> Remove cross-vendor support now that VMs can no longer have a different
> vendor than the host.
>
> While at it, refactor the function to exit early and skip initialising
> the emulation context when FEP is not enabled.
These two things are at odds. Two patches please.
The first which strips out is_cross_vendor() and initialises
should_emulate to false, to be this patch in conjunction with the
changes for the UD intercept.
Then a subsequent patch to rearrange hvm_ud_intercept() to DCE some more
in the !FEP case, which is no-functional-change.
In fact, I've got half a mind to suggest 3 patches, with the middle
patch being a strict un-indent of the the current "if ( FEP )" clause.
I think that will make a very a surprisingly legible patch 3.
The result will be much more coherent for future archaeologists to follow.
~Andrew
|
