[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86
- To: Chengwen Feng <fengchengwen@xxxxxxxxxx>
- From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
- Date: Tue, 10 Mar 2026 12:53:05 -0500
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Paul Walmsley <pjw@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Alexandre Ghiti <alex@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H . Peter Anvin" <hpa@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>, Kees Cook <kees@xxxxxxxxxx>, Yanteng Si <si.yanteng@xxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Kai Huang <kai.huang@xxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Thorsten Blum <thorsten.blum@xxxxxxxxx>, Kevin Loughlin <kevinloughlin@xxxxxxxxxx>, Zheyun Shen <szy0127@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>, Xin Li <xin@xxxxxxxxx>, "Ahmed S . Darwish" <darwi@xxxxxxxxxxxxx>, Sohil Mehta <sohil.mehta@xxxxxxxxx>, Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, James Clark <james.clark@xxxxxxxxxx>, Besar Wicaksono <bwicaksono@xxxxxxxxxx>, Ma Ke <make24@xxxxxxxxxxx>, Ajit Khaparde <ajit.khaparde@xxxxxxxxxxxx>, Wei Huang <wei.huang2@xxxxxxx>, Andy Gospodarek <andrew.gospodarek@xxxxxxxxxxxx>, Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>, wangzhou1@xxxxxxxxxxxxx, wanghuiqiang@xxxxxxxxxx, liuyonglong@xxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 10 Mar 2026 17:53:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 10, 2026 at 11:20:48AM +0800, Chengwen Feng wrote:
> To unify the CPU ACPI ID retrieval interface across architectures,
> rename the existing get_acpi_id_for_cpu() function to
> acpi_get_cpu_acpi_id() on arm64/riscv/loongarch platforms.
>
> This is a pure rename with no functional change, preparing for a
> consistent ACPI Processor UID retrieval interface across all ACPI-enabled
> platforms.
Really a question for the ACPI folks, but my preferences would be:
- Simpler name for the interface, e.g., "acpi_get_cpu_id()"
- Single prototype in generic header, e.g., include/linux/acpi.h
- Split the x86 part to a separate patch and maybe (a tangent, but
looks dubious to me) figure out whether/why xen needs xen_vcpu_id
to be ACPI CPU IDs
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Chengwen Feng <fengchengwen@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
> ---
> arch/arm64/include/asm/acpi.h | 4 ++--
> arch/loongarch/include/asm/acpi.h | 2 +-
> arch/riscv/include/asm/acpi.h | 2 +-
> arch/riscv/kernel/acpi_numa.c | 2 +-
> drivers/acpi/pptt.c | 16 ++++++++--------
> drivers/acpi/riscv/rhct.c | 2 +-
> drivers/perf/arm_cspmu/arm_cspmu.c | 2 +-
> 7 files changed, 15 insertions(+), 15 deletions(-)
|
