[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] x86: Remove x86 prefixed names from hvm code
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 10 Mar 2026 16:40:43 +0100
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: roger.pau@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Kevin Lampis <kevin.lampis@xxxxxxxxxx>
- Delivery-date: Tue, 10 Mar 2026 15:40:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.03.2026 16:29, Andrew Cooper wrote:
> On 10/03/2026 10:26 am, Jan Beulich wrote:
>> On 04.03.2026 20:53, Kevin Lampis wrote:
>>> struct cpuinfo_x86
>>> .x86 => .family
>>> .x86_vendor => .vendor
>>> .x86_model => .model
>>> .x86_mask => .stepping
>>>
>>> No functional change.
>>>
>>> This work is part of making Xen safe for Intel family 18/19.
>>>
>>> Signed-off-by: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
>>> ---
>>> I couldn't find any information about these Intel family 6 processors:
>>> model 0x5d: /* SoFIA 3G Granite/ES2.1 */
>>> model 0x65: /* SoFIA LTE AOSP */
>>> model 0x6e: /* Cougar Mountain */
>>> Should I add them to intel-family.h?
>> We should keep that in sync with Linux, I think, so "no" unless you mean to
>> first have respective entries added there.
>>
>> 0x5d is listed in the SDM, so I'd recommend keeping the entries (using IFM()
>> directly for the time being).
>>
>> 0x65 and 0x6e aren't listed in the SDM, so may never really have hit the
>> public. Respective cases can perhaps be dropped, but such dropping would
>> again likely better be done in a separate change.
>
> These are the 5G basestations I mentioned during the x86 meeting. Linux
> has declined to take take these models into intel-family.h because
> they're not general purpose.
>
> I suggest we drop them, including 0x5d. I can do a separate patch.
For 0x5d it's not quite clear what the justification would be. Looking at the
SDM, those X3-C3000 don't look any more or less general purpose as C2000 and
C1000. I guess I'll learn once you've sent the patch.
Jan
|
