Re: [PATCH v6] xen/domain: introduce DOMID_ANY

["Anthony PERARD" <anthony.perard@xxxxxxxxxx>]

On Fri, Mar 06, 2026 at 06:54:52PM -0800, dmukhin@xxxxxxxx wrote:
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index bfc9149096a3..79af2958d170 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -666,7 +666,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config 
> *d_config,
>          }
>  
>          for (;;) {
> -            uint32_t local_domid;
> +            uint32_t local_domid = DOMID_INVALID;

Surely, this change is unnecessary?

>              bool recent;
>  
>              if (info->domid == RANDOM_DOMID) {
> @@ -681,8 +681,10 @@ int libxl__domain_make(libxl__gc *gc, 
> libxl_domain_config *d_config,
>                      continue;
>  
>                  local_domid = v;
> +            } else if (libxl_domid_valid_guest(local_domid)) {

You meant to check `info->domid`, right?

> +                local_domid = info->domid;
>              } else {
> -                local_domid = info->domid; /* May not be valid */
> +                local_domid = DOMID_ANY;
>              }

Cheers,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech