[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/16] xen/riscv: introduce basic vtimer infrastructure for guests
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Wed, 11 Feb 2026 16:31:38 +0100
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 11 Feb 2026 15:31:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2/11/26 3:51 PM, Jan Beulich wrote:
On 09.02.2026 17:52, Oleksii Kurochko wrote:
@@ -105,11 +106,14 @@ int arch_vcpu_create(struct vcpu *v)
if ( is_idle_vcpu(v) )
return rc;
+ if ( (rc = vcpu_vtimer_init(v)) )
+ goto fail;
+
/*
- * As the vtimer and interrupt controller (IC) are not yet implemented,
+ * As interrupt controller (IC) is not yet implemented,
* return an error.
*
- * TODO: Drop this once the vtimer and IC are implemented.
+ * TODO: Drop this once IC is implemented.
*/
rc = -EOPNOTSUPP;
goto fail;
Shouldn't you then also call vcpu_vtimer_destroy() from arch_vcpu_destroy()?
Yes, it should be.
Thanks.
~ Oleksii
|
