[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] nvme-pci: fix parameter order in nvme_free_sgls() call

To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Wed, 28 Jan 2026 07:59:05 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>
Delivery-date: Wed, 28 Jan 2026 14:59:20 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 27, 2026 at 08:59:06PM +0100, Roger Pau Monne wrote:
> The call to nvme_free_sgls() in nvme_unmap_data() has the sg_list and sge
> parameters swapped.  This wasn't noticed by the compiler because both share
> the same type.  On a Xen PV hardware domain, and possibly any other
> architectures that takes that path, this leads to corruption of the NVMe
> contents.

Thanks, applied to nvme-6.19 with updated subject.

References:
- [PATCH] nvme-pci: fix parameter order in nvme_free_sgls() call
  - From: Roger Pau Monne

Prev by Date: Re: [PATCH v4 2/3] xen/mm: allow deferred scrub of physmap populate allocated pages
Next by Date: Re: [PATCH v9] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Previous by thread: Re: [PATCH] nvme-pci: fix parameter order in nvme_free_sgls() call
Next by thread: [PATCH 0/2] xen/balloon: fix balloon driver initial target
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.