[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Partial revert "x86/xen: fix balloon target initialization for PVH dom0"


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 22 Jan 2026 12:03:47 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXIK/3D4yTLUJgAeKxFe8bdxIid2/wGTCuYP5+LSRUk=; b=Fja7NWduJ2Kk8aAzF1ARFmM8F3p+Uif1lshVjAzzUzNZAXPzD7b0KUzJAADqAnofSWtkUIiIOzAV+sHHmYGHDmtfEKzbrjUQsy7yFOlabWXREfgqZJsv1OgQXemmik9sR6+yyLC2wYvcvfX0rUwUuZ1hOf30FhApFRVEsINKCp+NFENRaA8LS68RHBs3Ly32xyG9iJXnVA8INpicbr4+o7oAER3zwLVazO+Gt5b9yrh93nt4M4+BqpLtCBkVfK9KvQ7Xq4Axg10MYKIr6QotkxvyrtyFEALsUXAc/OfcdFQJRiUGF1Kfd61jTO50mDNe4x4CcSg9d8qoDngMxEOp8Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ohvXfhrQC2VdVKxyVNAix/KsOmxd8/ZIwQkpU4pPaV7yXiSwa21rJOYD4RMP9Fm5DFsZ31C8FYb2+nnfNrKcoQquZzg+9OL6nJ9a7pUfWOOUmrimS0e9kCuI5YvjFnyyq6cTxMoGoQu7j4a+RYLlOAiUfvBeGljDKi58gYEQ5GjK0vNbr0iyWBY2XrPhFP+qucgYfetmxwWNPL3ivWU9Hdzj/z7qP0ZOYD4tASJSVJrxaUSNRq7nkfU6p2rMbweAJSI3QcuxxaOG/pVZBfZjFZ0awDkY0oBPuUTaDpxM254t1b17EumEq7cmk9/YdXOB4HmeieI9x5E53CitpaSUcg==
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, James Dingwall <james@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
  • Delivery-date: Thu, 22 Jan 2026 17:04:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-01-22 11:57, Roger Pau Monné wrote:
On Thu, Jan 22, 2026 at 09:40:01AM -0500, Jason Andryuk wrote:
On 2026-01-21 12:49, Roger Pau Monné wrote:
I haven't tested it yet to see whether that's OK to do on PV, I would
think PV and PVH would be the same here, since the setting of the
xenstore target value is based in the return of
XENMEM_current_reservation for both.

On a system with 32GB and dom0=pvh dom0_mem=7G:

[    0.295201] xen:balloon: current_pages: 1835007 get_num_physpages 8220126
xen_released_pages 6385120
[    0.295201] ------------[ cut here ]------------
[    0.295201] Released pages underflow current target

8220126 - 6385120 = 1835006

And also for PV:

[    1.406923] xen:balloon: current_pages: 1835008 get_num_physpages 8220127
xen_released_pages 6385120
[    1.406928] ------------[ cut here ]------------
[    1.406931] Released pages underflow current target


So we don't want to subtract xen_released_pages for dom0.  Is
xen_released_pages expected to be non-zero for a domU?

Oh, yes.  In fact I think the patch here is wrong for PV dom0, as it
shouldn't subtract xen_released_pages from xen_start_info->nr_pages.
I will need to send v2.

To be clear, the numbers and warning are from the follow on current_reservation patch.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.