[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 7/8] x86/HPET: drop .set_affinity hook


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 22 Jan 2026 11:05:08 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2P0OrTzrEB8z8isqkI+y7pRtgtDM55aReYKK6wcLRyw=; b=sleFYB/lvV0XXcoshUYj+7jkaosrcK8nWyzLekr0kEtUDpw8yLbjcNBbVK4KVtHopO4pkGAipKbQtrd12Z1ONZFYwE1uxVtW8TebjWSLRp7YRDH40MS+xfqaci4R75k+XOTOWrj75wjJljU+6sWgGusXtPaoT8+4LEf7p4H3rJiu4oS2nicV9xJGLru+lw86uIpvA4ckpLmGOeevBos1idXRCAH3fXvonq7x9LyLVXAbNFFezbJHePw/Ed0/iudmn/b+veFNpnamdEoM8nlfX+YPG3082FeqLVnmLUcCloa82UBRw+Z8bDxXCUR3RDfXKce6nVeyVS+fx1OW+4skmA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nXXw03V9QtBm0dB5stzl0iVhWiz19MQmGmfxhHZFNDjVBzGl/OQZfFrUkyJzu5IruLMgrgatnwwCXFE3LPsss0Puk9+loxnTQzJcpmap7zDp8L5Pb37ZNZLNIgbF3oNauhS3rF5s7zMpOocdfGbP3oacHRTP13cFTiZqx5ftJUWxZd10rzIbiv2M0yfbalcoCbnrS04ZAfhAecLdYFRp3vyIC8BVRam+0yn679RQZ5ikRKlEw7D6Kq24Ow1Bcf5+akiFlEwA2MuAkQhkqw91TW6VOPTwwPCUIUpDe652Jx8W48LHa14R1irz1yupj8pp/ZNH5PSeCijrN5IuX55v1w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Thu, 22 Jan 2026 10:05:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Nov 17, 2025 at 03:39:50PM +0100, Jan Beulich wrote:
> No IRQ balancing is supposed to be happening on the broadcast IRQs. The
> only entity responsible for fiddling with the CPU affinities is
> set_channel_irq_affinity(). They shouldn't even be fiddled with when
> offlining a CPU: A CPU going down can't at the same time be idle. Some
> properties (->arch.cpu_mask in particular) may transiently reference an
> offline CPU, but that'll be adjusted as soon as a channel goes into active
> use again.

Hm, we where likely pointlessly migrating the HPET vector in
fixup_irqs() previous to this change, but such movement shouldn't be
fatal, just pointless.

> Along with adjusting fixup_irqs() (in a more general way, i.e. covering all
> vectors which are marked in use globally), also adjust section placement of
> used_vectors.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.