[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] CHANGELOG: Note the new SVM bus-lock intercept


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
  • Date: Thu, 22 Jan 2026 10:24:32 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/oFnyNESESwLZyDcTFYh20C3cx2/Zljso7Pp2lKN9A=; b=roxdxz/N7979wNKhIjVF9vO7DWXGmcqFydx/nOiCdIdxbMVMwd4rHdttmFCHxeCgm0h9xgdiuJQVjEF4dqOCVw0R6sTs7v8PUmozCNOdx0pQe0Ar+88w0U7ZsEAPKexSG6EF2j3m4M0l+Pt1jb3jLxMUvuB6a44ZF5yb3x8FMB/wKs8RYV3gIPx6OiJWnJUftywrj14V7RYdhSDg3mT2tiyNGwZwMEQkAEhUXAiFRmANflpDjPHMUY4KEru92OfaZom1uIfRvwK46LkWLhOVQoCtm3Crprtu4krn0wQGBYTFPO4HkXRPPGg9GcJJ2t/Z4XroPw6aXGup/Jo8qTOKBA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PnKNF3C7Zjqh2EZc5k67a/RLjGvBz52E8kiXRNtxG33ANUo4QupJPes+oEAUJn1Klg/g/0zxcOEm+CcUZbme48n0XDNSbaQVZaWFOoXn9EwsSNzfkBXTHJX7x7QrnLuSSsdaAQ35XUXYxiGgeR47u11jfdAGkiIrEj2tqJl8j0+UaPXDJbADvRBAFmIXidIzl2e22XFFiQETnsG7erpCo2cSlfuvIU8sRq3ys25U/OxM9vmoB0/6yXklBrTyu5D+T/rasS1T1ReC0iGUsuK8RDP4MSHaOyG5yx9ADUrw1MEOOyHuxZrT9wHKPIxkfzYJMq5D29y1VxLOW2gHvi9mGg==
  • Cc: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>
  • Delivery-date: Thu, 22 Jan 2026 09:25:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed Jan 21, 2026 at 7:36 PM CET, Andrew Cooper wrote:
> On 21/01/2026 2:28 pm, Alejandro Vallejo wrote:
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
>> ---
>>  CHANGELOG.md | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/CHANGELOG.md b/CHANGELOG.md
>> index 53d92a2597..07c1745f22 100644
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -9,6 +9,9 @@ The format is based on [Keep a 
>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>  ### Changed
>>  
>>  ### Added
>> + - On x86:
>> +     - AMD bus-lock detect, used by Xen to mitigate (by rate-limiting) the
>> +       system wide impact of an HVM guest misusing atomic instructions.
>>  
>
> A little too much copy&paste from the SPR section.  This wants
> unindenting by one level.
>
> Also, this text most importantly needs to identify which hardware the
> feature exists in.  I've reworked it to:
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 53d92a259731..9c3bf0411ccc 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -9,6 +9,10 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
>  ### Changed
>  
>  ### Added
> + - On x86:
> +   - Support for Bus Lock Threshold on AMD Zen5 and later CPUs, used by
> Xen to
> +     mitigate (by rate-limiting) the system wide impact of an HVM guest
> +     misusing atomic instructions.
>  
>  ### Removed
>   - On x86:
>
>
> The internet suggests that it's Zen5 rather than Zen4.
>
> Also I personally put the CHANGELOG update in the commit which finally
> implements the feature, rather than doing it after the fact.  This is
> more helpful when git blame-ing CHANGELOG to find things.
>
> ~Andrew

Sure, fixing up the prior patch sounds good to me.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.