[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] earlycpio: lib-ify earlycpio.c
- To: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 21 Jan 2026 19:37:27 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hSIQnihWBTGLNNhyFlRPTs2hQiNRhL30wvoBa53DoMg=; b=b0QFxkeYMnAKy/LQqSu5ZizwVrP5f7+rfzv0mH/58zwQPJqRszZC0ZOIsUsNfXjPbBEpgzpR/04/iE5WMPOwm8Or1pPxOh05v+NmN9BvxEvXp9/eEEBY4gqTQbVqZiABXFtOTVYtBCk4NSDaudLEnqTmvs30jz73NinRDELrwZmc5/KZXbU6ahbKb9hjYOdyJ12MYdb1vQ8tQBxJNqKbcHwzS+u5WaJGX2AoJ0mHmx+J077GuMLHfy/BmfsakA1QetgHXjm1T9ymcQXbqpIzxeb2UX2Yea5e8gL2yrTto6d8USE5F0GEQsWiqJfGeaYFcogRlKF2vxHh8YMl6X872g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m/89oHjKfvI/zsGj4o2Bp6lxE7FRYYBadjUTvmTpcTDIpcbyMJGCfu/4zenRHswB8kVDGqeAoev1m/XXqxoApSay4pJzgdPu1dhA+bi53BL57b1KFJQmZKArSOaJQCzSdPSHZQChGYfmHOrfMkHze/w9XKtFSwgAhmn1hyoEPbNjVPgMddfGi+w7X2vyQpOOem7+vjE6bPpFP7ZVRZMrpU/sUkepvhkgdIpmWluvx5y2sDFxgfV6MGX1V9ie5TDljhGvRvHA13o3L8dn26av/IqOhp8mpgX+9xIy4wIDLT/qd3YWQ6B8PufxlBTXSAu2mwVb3HLxca1uQUqLMc6+qg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Delivery-date: Wed, 21 Jan 2026 19:38:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21/01/2026 3:47 pm, Alejandro Vallejo wrote:
> It's only used for microcode loading on x86. By lib-ifying it we can make
> it go away automatically when microcode loading becomes an optional
> feature in follow-up patches.
Given what's committed, this becomes "when CONFIG_MICROCODE_LOADING=n" now.
> The exclude-list.json file goes stale after the move, so remove the entry
> for earlycpio.c now that it's not included in AMD's build.
>
> Its breakages will be fixed in due time and not ignored.
---8<---
exclude-list.json becomes stale with the move, but earlycpio is now
absent entirely in the *-amd target build, so the violations don't matter.
Simply drop the exclusion, so the logic gets scanned as part of the
*-allcode targets.
---8<---
>
> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> # lib-ify only
> Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> # exclude-list.json
Consider my A-by extended to a full R-by, and this looks fine to go in now.
~Andrew
|
