[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Partial revert "x86/xen: fix balloon target initialization for PVH dom0"
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 20 Jan 2026 16:33:07 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dy496zTH/Lr4IN5cUi/7GmFfoC/qmaNauHa9lWQdFw0=; b=phWZQY3SPcqi/iuz7yWSFiLwEcMqYBmACsQGsg3/se6w2VtV4liS0gvc2p+FBzCYMsbJldIVOY3NKfYRxWVgBKaASeNI6DTK5tsSAtuwZONAO8FVDcxEop9JfArgbPnRnAO/U2ygFMQd8+qyHFc3JYOEaWikJgC469ei5gjtWmmw/aMykaiDAH2KEVWrPF/2vs7gY/almFR+VG40s+SNEP3HcxB33WQYqdOfk/jZ2qAvAh7GOpkwwK7EWJ0i/BPtD+8oJTL61HiLQj65z1RvivnJnQtIAr2G7JV17KV1tgHyRQuhLd07kyxEJzvHw521AdxmYZj0JKWPrFQha9qWgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=achTzX66ko6AXWtAetp9orG8EnuuGZmRZsWhN9naL6ZX9wH52aPnhLfAioF29V2qt5w4pS6YzVknA5nPBxVshNVAil6EwNcQa0DC7ewQswNP9d9UWCXQSCVpF2xZNIFE1LO78lU0aMpunAffDcSckwtpZS0OyDATIYZKgDcwz74rZluxeUlHs6ktubJnJqdoBo0qlwmsXeiltfR8/UTDWjsGvtiFkdeo0tF17kIvktK1JoJL2SCAuzOm1F0DEhkVusxseastOmPFZmktEsE5MwxSqEGL3XGaTwVxIO7ojyCZdXx4/nkdHXOWlH6ovJpfFZ9ZQyrtGDq4dA0GvzSK0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: linux-kernel@xxxxxxxxxxxxxxx, James Dingwall <james@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- Delivery-date: Tue, 20 Jan 2026 15:33:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 20, 2026 at 03:06:47PM +0100, Roger Pau Monne wrote:
> This partially reverts commit 87af633689ce16ddb166c80f32b120e50b1295de so
> the current memory target for PV guests is still fetched from
> start_info->nr_pages, which matches exactly what the toolstack sets the
> initial memory target to.
>
> Using get_num_physpages() is possible on PV also, but needs adjusting to
> take into account the ISA hole and the PFN at 0 not considered usable
> memory depite being populated, and hence would need extra adjustments.
> Instead of carrying those extra adjustments switch back to the previous
> code. That leaves Linux with a difference in how current memory target is
> obtained for HVM vs PV, but that's better than adding extra logic just for
> PV.
>
> Also, for HVM the target is not (and has never been) accurately calculated,
> as in that case part of what starts as guest memory is reused by hvmloader
> and possibly other firmware to store ACPI tables and similar firmware
> information, thus the memory is no longer being reported as RAM in the
> memory map.
>
While kind of obvious, I guess this needs a:
Fixes: 87af633689ce ("x86/xen: fix balloon target initialization for PVH dom0")
So it doesn't fall through the cracks for backports.
Thanks, Roger.
|
