[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/5] x86/ucode: Add Kconfig option to remove microcode loading
- To: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 20 Jan 2026 14:09:37 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0UruohLUsRKdrKxS02n9udW8OL+3E2mfwtuJ1S5dpTs=; b=Eq3CzoAhqEZG4zAVCYCHE2AeUL5VQtHLlm80lG18t1Bqkgy3bTqoUU1YlDpgL6jSqXMLUU7dLdNMNWyITXogg6W14XsHm88OpnQ2XM5dvkSir8+x78/8dbnGWpmwK06mfi+NyjmfK69hrDFOIzXyztOPz2gabX2lZ51NjRjI1U4CvWYNovOzdqd2s6ZD47ZGGlHWj1ZAvzN6o/pu9deCaLUc6k8ODACF4L3yZbFkmdkYHMWiOohr/bcDP6fzLC9lOGt0AsbEUvXn/H+H4KOldibt8NWs9YLr2VdhdVpjqAxo/+dLQk9QJcUiEz//GGuiVnM606OhgJQQC5yrYIvLpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kpzqQd4/wPiXgNxUGv91N/L+1g2Yn5cVD1gd/Ir6x7SGszO32/+HaWp5X+qVME8DD1fWYdJwzdzjzPdghV09mg8phmqUChb4XrQP9FB5X3Cn80yyCdjUescXtMLBy8qk9tCTzymZtHRN8yd4EY6c0KP6cdZyHNIgW1MSJBNeqyLBHmKk1p8wMG4QGRhLSyaSQda7y/ouYiN/UuNp675EN10c3Ty8ia3GRQEGvhI5HTtgF5xb6DurrhZ32zYGKmJvo9ln6KmZHMH0FTB8mrCK8w59OCrobHEpfQ5IfU0cnRzTEu/GcHFu1ahmnkx9xc1p+ZsW6u6wJUSG/jouMxBRlA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 20 Jan 2026 14:09:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20/01/2026 9:38 am, Alejandro Vallejo wrote:
> diff --git a/xen/arch/x86/platform_hypercall.c
> b/xen/arch/x86/platform_hypercall.c
> index f8eca48170..2ac9fc2d96 100644
> --- a/xen/arch/x86/platform_hypercall.c
> +++ b/xen/arch/x86/platform_hypercall.c
> @@ -317,8 +317,11 @@ ret_t do_platform_op(
> {
> XEN_GUEST_HANDLE(const_void) data;
>
> - guest_from_compat_handle(data, op->u.microcode.data);
> + ret = -EOPNOTSUPP;
> + if ( !IS_ENABLED(CONFIG_MICROCODE_LOADING) )
> + break;
>
> + guest_from_compat_handle(data, op->u.microcode.data);
> ret = ucode_update_hcall(data, op->u.microcode.length, 0);
> break;
> }
> @@ -327,8 +330,11 @@ ret_t do_platform_op(
> {
> XEN_GUEST_HANDLE(const_void) data;
>
> - guest_from_compat_handle(data, op->u.microcode2.data);
> + ret = -EOPNOTSUPP;
> + if ( !IS_ENABLED(CONFIG_MICROCODE_LOADING) )
> + break;
>
> + guest_from_compat_handle(data, op->u.microcode2.data);
> ret = ucode_update_hcall(data, op->u.microcode2.length,
> op->u.microcode2.flags);
> break;
Very minor. This diff looks like this because you've dropped the blank
line between guest_from_compat_handle() and ucode_update_hcall(). That
can also be fixed up on commit.
~Andrew
|
