[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] x86/svm: Intercept Bus Locks for HVM guests


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
  • Date: Tue, 20 Jan 2026 10:53:50 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tlelRD0l8IWBcWpAH3Cc0918m2Klv7LDj+1fptSjsws=; b=JiIA6TSQ3fm68JLI7oqZLabjgvnVwgvTbEuCaT3i7cQM2XzPShXpBJAm9cdA1Xi2Jhnb0IfQ0QchUVlLVgbUnyQzutqFGCGv+mqbAjCtq+eTiNOiPrEMk7qi813eeVYPtLn5W7oljsA+Pl9SB2l3lKQCd/gXfq4XWVsB6XBTumy7tgUq9bNcB58aN87srxXvpdD5yX6nLl73Ykvf806Ckqaajz+c6grxZJV+WD0CZvRaldkwQkUUvpkdyBRblVzVERzUV6AkMayC1qQDrIcLuE4PTAd3jfCEsPusGhBRKnLPgVJ28EAwkPukeN48sCPxYha265mzxrVq8WIbDIQNWQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yyvFWv3+VBwTDB5ly/AP9wyGd+/7w/KDiK488McpzGROGreGOws/ELXAdwJvmh6v03k8QLewq+X/PQglv/rHY8tTmbYgP9D+KM5Ao2/zalvwASpORK2X52ROoECvgA4nGtcY9745Den6XuO3SpKxBnCZgiJANdYgrypiDS28BYGJmD3ZwPE3rOWfks94iUX2ijRJzEtpEX5Dq1LejmvRhxspU48RW66zh0hlBcZ4eV48JQkA7mdYEb/1mcUhRD4QfH9K3yDKAi3ExkCFkM8+BcGRz3ougucWdt5/eJRAUYOIvnqaIHlrHrkLKRfo2wVvQ81ORddDaCyTe4JG8UoxHA==
  • Cc: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 20 Jan 2026 09:54:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

With the threshold initialised to 1 the guest exits at the first
buslock. Initialising as zero is invalid and causes an immediate exit.

Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
---
 xen/arch/x86/hvm/svm/svm.c  | 4 ++++
 xen/arch/x86/hvm/svm/vmcb.c | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 9748df87d8..dbb7f99d5e 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -3087,6 +3087,10 @@ void asmlinkage svm_vmexit_handler(void)
         hvm_descriptor_access_intercept(0, 0, desc, write);
         break;
     }
+    case VMEXIT_BUSLOCK:
+        perfc_incr(buslock);
+        vmcb->bus_lock_thresh = 1;
+        break;
 
     default:
     unexpected_exit_type:
diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c
index cbee10d046..7a19b1ab61 100644
--- a/xen/arch/x86/hvm/svm/vmcb.c
+++ b/xen/arch/x86/hvm/svm/vmcb.c
@@ -66,6 +66,12 @@ static int construct_vmcb(struct vcpu *v)
         GENERAL2_INTERCEPT_XSETBV      | GENERAL2_INTERCEPT_ICEBP       |
         GENERAL2_INTERCEPT_RDPRU;
 
+    if ( cpu_has_bus_lock_thresh )
+    {
+        vmcb->_general3_intercepts = GENERAL3_INTERCEPT_BUS_LOCK_THRESH;
+        vmcb->bus_lock_thresh = 1; /* trigger immediately */
+    }
+
     /* Intercept all debug-register writes. */
     vmcb->_dr_intercepts = ~0u;
 
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.