[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/altp2m: altp2m_get_effective_entry() should honor ap2m->default_access


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Petr Beneš <w1benny@xxxxxxxxx>
  • Date: Mon, 12 Jan 2026 20:09:06 +0800
  • Arc-authentication-results: i=1; mx.google.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hqE0n/BHfuGpBhKc4gDOFo1HDXq1DAZHir7z66JW3p0=; fh=64sy4YBgBXGN17F8up8usSaCG+1UZhpwtGHg+RL4oUw=; b=VoMBHQy7DOQu6hA8MJZdYuiOlxD/cTwJh0voi+yAy+SUa1HOQWJCRj50jQtGBqtNSf k9irlCpYf8QBOcaSp013XWpADLuBhZkF01A/kb6jwsrheHfOgoexuk7h+P9jmnTynqo8 EaKFRw4F/XxnzHnVwbC465wXQAYQKLN1V+ZedPc17TwzYH4A9566L244i3mqZUe8fDw1 xa4vHzFBwk8EXbMYOGH4mha0ka7y1rLSbJbeeUMR5N8yM48vEYQm2OfW396j1DHVqKj7 xQdyrb9VMVs5WEN/YxhJ5wNAh2GJ9BKg2MdUzI5lXNjvPqR5exGs2Svi3BC5zvcXuD7H L0KQ==; darn=lists.xenproject.org
  • Arc-seal: i=1; a=rsa-sha256; t=1768219757; cv=none; d=google.com; s=arc-20240605; b=dNg8M295M+AqSjLfrfk6mVfqIPNcnXGJ4xMEJ98EU5bOVL4koBf5e7h4HEcoV7f7wZ xcFZaULluewxDH+7+yTr2nUBplQD671ci5yiBrvRJu4AO08qigQNikcXeeKcpXzXORtq 8iRBYrW7eTvKgOTVios6+wS+lkArGyP3Z3My/uWfrZUzmvrtG3377mxEj1SISCR6fFU/ D7FAUJ2rIVR2JPdyyNxkqMiGLK0A08Vst6/MIEUQCTzGLAifXrCnqpfCD01lGnCZSFHd 4/GmyoMVXmoNE7QLH8a9etX45TrkYrMA3XhqAQUAYu9LXNAsKFAZ4/moA2UBsICatYOA UOug==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 12 Jan 2026 12:09:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Jan 12, 2026 at 12:24 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 12.01.2026 12:18, Andrew Cooper wrote:
> > On 12/01/2026 11:09 am, Jan Beulich wrote:
> >> You didn't even Cc Tamas, who I think once again will need to ack this.

I _considered_ Ccing Tamas when I saw add_maintainers.pl didn't add
him. I couldn't remember if I added him manually at that time or not.
However, in the end, I just trusted the add_maintainers.pl and didn't
modify it.

> >> However, two formal points: Please use 12-digit hashes, as demanded by
> >> sending-patches.pandoc.

I apologize. This is the first time I'm learning of the existence of
sending-patches.pandoc. Up until now I was following the
"Submitting_Xen_Project_Patches" wiki page where nothing about how
many characters of the hash should be included. I'll keep that in
mind.

> >> That earlier change of yours didn't mean to do more than it did, by its
> >> title and description.

True. Had I known at that time that the fix is needed to be applied in
multiple places, the commit message would look different.

> >> We relatively recently introduced Amends:, which
> >> may be a suitable fit here.

So, what should be my next steps? Should I re-send the patch where I
Cc Tamas, use 12-char hashes and replace Fixes with Amends?

P.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.