[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86: fix incorrect return value for has_if_pschange_mc


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
  • Date: Fri, 9 Jan 2026 11:43:30 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BkB6EsBblYtcdg4TthQlzoq+zGj2omHbzRe0YMZrHm0=; b=lLVSHetqKaliFVNYB3F5F51aP2bPzyFxt8GsUPWTMSW1WWRAgIUpoTtPMRqMZTqicB/i/OQC6EQ3tm55gsrYGVSxigpOVcA5jpLCQCBOyqKuLVoQvzDeyGw/gnhT1mDny7DgKJ7MPa2ewBCIrjyQIvoFnOwApXuDpNoHyEZkNTOreIi5OlxDjHXUmSzK3DotYCzC1SmLLL5daBpgE3WYFf6J/1JYpVqjfzRHX65oZRsYyApomKKxwAMoZ3TPVaKt9iKy/I4i+hDf0XNwuo1SMj7+Q1mwZNvSyLf/mgPyi3dpstRxPwPYReXcS2zxkSM8OEFb4YpJMzC9INXk2X5omg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c5ecxi5Qg/5K1fybrloba/RN1gcIfHPrODDRA9TUYtLWIcsfnixDs/arvDIRQid6fH/glZwqVGFRGxnv4/EB3YA4tWo8jM4L0HvY9WOp7pMQhhbsX+QC1AcoWkJC0wtVVFacwLCD2OSd2O9scIqa84AW/MBBMGkPxcyCMxL7z0U+DCAYoDqKNqp7+zIzEfz2PzL3zuEZ/7tpB3lheadgT83A2C3R5DpWB1Os0oEvKW/PbAKwwZsKT731k58A6/Q4WQeyh4zgIoPsZ72LwJ1Xa/KX6EON4qCA/uz3FULQVaTitRgTeYz9Q1L5xPVMt+B2XVHqseaQkjv4u3IPqKSB/Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: jbeulich@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Kevin Lampis <kevin.lampis@xxxxxxxxxx>
  • Delivery-date: Fri, 09 Jan 2026 11:43:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

A return value is missing from this function leading to safe CPUs being
marked as vulnerable.

Signed-off-by: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
---
 xen/arch/x86/hvm/vmx/vmx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 05b59cb8e4..cf474ee5b3 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3117,6 +3117,7 @@ static bool __init has_if_pschange_mc(void)
     case 0x75: /* Lightning Mountain */
     case 0x7a: /* Gemini Lake */
     case 0x86: /* Jacobsville */
+        return false;
 
     default:
         printk("Unrecognised CPU model %#x - assuming vulnerable to 
IF_PSCHANGE_MC\n",
-- 
2.51.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.