[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] xen/arm: vcpu_vgic_free() updates


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 23 Dec 2025 12:36:40 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eccSa/J37gwASMRRFlnVVl3pc7ECyxKGqkatMbHQqaQ=; b=FrMwRVAhCL8HLFrRGNFyestASPYghV+UzmxgUKo9Iek94poBmZa0L3bA+fQIBPOlt+XYI+4NQTIQCEBKnSooF7TovuHCABSstLdXCxPRR8as1cW7OPxPvhD3Qbo5oHp+artAmkSgrsv9zj63NW9hk+1qaab4KVLvRHB+Z8HfeQHjRAKyFxd/B867sBBDrqZ60x7resg8gThpoUNw1Cih7w5y1RKoWxRqzf/ihPikIOapuS01aogFtjG3eAE2c7eSyfH8eWYwIqk+0+WkmiS4o7wthSj7Aw35hM3QOCMBMR++yfBulo/84D5ZZFdBnNdwW5sbJfw5mBCtLeR3lWiSoQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GZoOVGvvZKF0/ScdPnBHKuckhtXthjCFxE+56VF29VvORQfFMZRc7rwOu0VdEBK6iWBjBIN0e5wZdncFEB68+uAouN/SAUqgLu0ZNGfAU3y4KTOGELB7NEwnhJ2/vopOo92osFtFzbXQtsUOd+W6NDrKhZodvaehqeFiWQPFD7ljnpFEQ9pjK+e0+ENNmCNRx7kib7+fFr4+0rlB9GkHM2OeD6ActrIt3QDaOM4S4Hgk+9/3n9BuTJ3hmLpyr/R4a2Y3YJpqE0UJ/9j7DBQ3CmHV3N55jpnXJZrAnLO2IoooD/VxBdvtHYOlKMMleztzWcxDYWMok1Qnn0UYKWHqoQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 23 Dec 2025 12:37:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/12/2025 4:40 pm, Oleksii Kurochko wrote:
> Use XFREE() instead of xfree() so that vcpu_vgic_free() can be idempotent.
> With XFREE(), vgic_vcpu->private_irqs is set to NULL, so calling
> vcpu_vgic_free() a second time is not an issue.
>
> Update the prototype of vcpu_vgic_free() to return void to satisfy MISRA
> Rule 17.7, since the return value of vcpu_vgic_free() is not used by any
> callers.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.