Re: [PATCH v7 01/12] xen/arm: Add suspend and resume timer helpers

[Julien Grall <julien@xxxxxxx>]

Hi Mykola,

On 11/12/2025 18:43, Mykola Kvach wrote:
> From: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
>
> Timer interrupts must be disabled while the system is suspended to prevent
> spurious wake-ups. Suspending timers in Xen consists of disabling the
> physical timer and the hypervisor timer on the current CPU. The virtual
> timer does not need explicit handling here, as it is already disabled on
> vCPU context switch and its state is restored per-vCPU on the next context
> restore.
>
> Resuming consists of raising TIMER_SOFTIRQ, which prompts the generic
> timer code to reprogram the hypervisor timer with the correct timeout.
>
> Xen does not use or expose the physical timer, so it remains disabled
> across suspend/resume.
>
> Introduce a new helper, disable_phys_hyp_timers(), to encapsulate disabling
> of the physical and hypervisor timers.
>
> Signed-off-by: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
> Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xxxxxxxxxx>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall