[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 22/24] xen/domctl: domctl_lock synchronization only when MGMT_HYPERCALLS=y
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Mon, 1 Dec 2025 03:56:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DFlNIrgKAk3A5Ta9l1UYobBJjq79wtHYQWjdYWgv3+0=; b=YQz519TeHeAN4VhHz9+lCRw7E7rF9CJby4GeBCDl6q02aPdl4h5b0vuiaoUdyJa1LxWm4B/WRDF6Gi6/qi5RUsr+DarC4kJPZrBh0TMZTa0W8UAKtTxfMUwbBP+Tm0T78MKGiyU17stoBtcUO3+OP0DhzxG4iKZ5xgJzZDrYPWsoahIWcpBMXDHQmjCAniqgfNPUOCQEnl2neDCLYymEA6NnLeDHustmNg9kvlIYC/1iPpvH6Q2HZOJEp2fDeApsvB6sXHtb5x8E/tgCpRPzES6Eymj9knZsDX/zDXL71FnvKPk6haltYTenQpVukhJfXxdiaAo8Rtzr8sLXoktyBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pNYn5NSCGZnsHueW6eVi4Ls/vf+oSXwqvylRu1nXYWeQM8GJeLSTfUZOOMfW3yRHQUmkjfqvs3x7XoqyHbS3DnLedpx9uOpQuIA6L5WsUkKCITeRdIAUoBblF7T5qhXnpTYy+iVKgQEjVaYYFcW+6ErxcIhIFUQVyqQJhjRUKviHgRJ1c8XpgaxOSRkc1dpKilvc37JEyfTfJX1QRuSj62/pKt8xkEufHIIH4Z6MJ4s31ohHG23s+rXJ0Fh/QVnwIEQHON+cNTs6KSy85kCzhbyaIb5UzFi20daqYb3aJtnp6TmtGtgs8Vn63CRGvr/7zYRYsbhRfK9PjMapTxj2kQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "grygorii_strashko@xxxxxxxx" <grygorii_strashko@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 01 Dec 2025 03:56:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-12-01T03:56:05.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcWtXpTPLVc9pgnEaS2HNYGgIlV7UEtj0AgAeAyGA=
- Thread-topic: [PATCH v4 22/24] xen/domctl: domctl_lock synchronization only when MGMT_HYPERCALLS=y
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, November 26, 2025 5:21 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; grygorii_strashko@xxxxxxxx; Andrew
> Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 22/24] xen/domctl: domctl_lock synchronization only
> when
> MGMT_HYPERCALLS=y
>
> On 21.11.2025 11:57, Penny Zheng wrote:
> > Helper domctl_lock_{acquire,release} is domctl_lock, which
> > HVM_PARAM_IDENT_PT uses to ensure synchronization on potential domctl-op
> altering guest state.
> > So it is only needed when MGMT_HYPERCALLS=y.
> >
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thx
>
> I'd like to note though that ...
>
> > ---
> > v3 -> v4:
> > - new commit
> > ---
> > xen/arch/x86/hvm/hvm.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> ... with this diffstat the subject prefix is pretty misleading once again. I
> may take
> the liberty and convert it to x86/hvm: (and then also add parentheses to
> domctl_lock()).
>
Will fix
> Jan
|
