[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen/dom0less: move make_memory_node() to common code
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Fri, 28 Nov 2025 10:22:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cPZ7W7SxxB1tXe0MmaLlPapNOfnEVEZrhQASAuU9JI8=; b=QZLpK/Qt5E0N8MYthdtgZDTosnYuprnujjE7oxl4adjkcp/n9ySI0QniiJNkYgvfG5N4HQTHufb3fJ8ajymYAu/il/kspLjKWHH0UaZCFGch7Wi75H/0WMYJIj25duIbABHUtnIyC8cRYQW3nSy/J21b1f/12i5ufIq3rm2Wz8l9W3EL3NQFAtHcbv1YdRoA2JqWCOUrqtk6ZlFdOuZrQlmnDXkv0bXwK6H0JD+hqgh0xeofdQaLlheEKcpeIg3AM8132XYV7oWQOZc6zX26EZuwDqOPR46nUMWRM2bQ4H07SgL1ve+G8dfOyQgbJbC/iwDgmnPgShDzOzFPElBsXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S4PUaX3cfeyivzL81GhGsRc04zMFOUH0GKLc82dv85/iBx79xgycRDfZvqb3nPzKj4qrxzb9W8pKrr9JUcPZ2CowZ8o+l+DLGVe2ttpDPHbd2G+1BWWBsZY5TrEEIE0pozwYlWzAfT0LMg3gOkPjNcIJRUG7T3IX6zfWkmhmnRWR8gAc11z4Q8ygnRsuWrHz9KhMhkrFzTFK5+Boy9kCyWLZTzdNEt4P3lG40g5P5OHlcCmqtddEh2bUkAnpBeJVqK0x3gBhTTMK4/q806Le78IpS2QOFYXrsLOuhZ/ERiQS7O6I8p7IlcUvuKWA6z6Lu6w1JKGyKsjoblSTqjAa1A==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 28 Nov 2025 09:22:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/11/2025 10:06, Luca Fancellu wrote:
> Hi Oleksii,
>>
>> diff --git a/xen/common/device-tree/domain-build.c
>> b/xen/common/device-tree/domain-build.c
>> index 774790aab3..6708c9dd66 100644
>> --- a/xen/common/device-tree/domain-build.c
>> +++ b/xen/common/device-tree/domain-build.c
>> @@ -8,6 +8,7 @@
>> #include <xen/mm.h>
>> #include <xen/sched.h>
>> #include <xen/sizes.h>
>> +#include <xen/static-shmem.h>
>> #include <xen/types.h>
>> #include <xen/vmap.h>
>>
>> @@ -451,6 +452,80 @@ int __init make_chosen_node(const struct kernel_info
>> *kinfo)
>> return res;
>> }
>>
>> +int __init make_memory_node(const struct kernel_info *kinfo, int addrcells,
>> + int sizecells, const struct membanks *mem)
>> +{
>> + void *fdt = kinfo->fdt;
>> + unsigned int i;
>> + int res, reg_size = addrcells + sizecells;
>> + int nr_cells = 0;
>> + __be32 reg[DT_MEM_NODE_REG_RANGE_SIZE];
>> + __be32 *cells;
>> +
>> + if ( mem->nr_banks == 0 )
>> + return -ENOENT;
>> +
>> + /* find the first memory range that is reserved for device (or
>> firmware) */
>> + for ( i = 0; i < mem->nr_banks &&
>> + (mem->bank[i].type != MEMBANK_DEFAULT); i++ )
>> + ;
>
> NIT: maybe we can fix the code style here, maintainers can give their opinion.
I'd prefer to keep the movement clean.
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
