[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen/dom0less: move make_chosen_node() to common code
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 28 Nov 2025 08:50:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mt58WoVL8z3lFCQlq8fkRyvg3543CR+7QjtFB/29Pfo=; b=j5ZMAid+EFsBFC7GOLRbbyYX3zM50AEhNSjJ41wIKdGxXSS8tU+pTawMDE05NzuCIU+HJy37WkQbgZDt1iiG4B+bzceB52GEHASJIgslPbzT0rsID6Uda2X1J2N/ICyPwhoNoh0DbzYMoN/5Sg9Itu/tKcbsKi/1/wxvFlOyyXzVX2bn3jRAq2bpUfPu2MTs/gctgy+YClLRTvJttxQp3ET1VML8VFTuJCK3Z8KP+l51VYitV/rKZd4P284pdJ9AdRR1LRNrnYxULrALzqjGibWLXWrAWKTtL3SUNETg5nAzpxRBnv3GTSziDJKPCCkeovHVWvN58UkyBL9XaVAHuQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mt58WoVL8z3lFCQlq8fkRyvg3543CR+7QjtFB/29Pfo=; b=vXgOJ5IPur7qjz+jdNq1pDGNyiGYID5BTHJaPdezCXcVSp8AtRxzeIrqlZoEjl0i+hX3hZ/z6q22vIwyDvEj79CdI1RmTaGxyZQoRQ0+JZ9swZvqsNrtEz+FfaKJgnCLJezbpbTxy9nqvBcfCp38VCEDysW7xG4F8lWMoTgXAvT5dLymh9VHln73CUXtBXGfzUtrwt/wmT0lo/Osc2iS2L5PcKNPsyPfLCYJ0SNkNIQMEgIg8Nz0RN7rgDZfVjXA1yvTFj2mCWBda29BAYKFXnuNdXKZN+rhyyolsj1S8LHIxTfS2jcAO7QHUh74fH1XC9R0XXK0t6/Y/WhyvQzXIw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=G01D3FrlbB9SvPCJIdb5WUdU+xNUCUxvjnsq+iU5BxoSZS+Ga+pD/pruyNcYQHPeW8LyBgjUooereUetVb4ZnxBj7PLJ7Jb5mChGhejUJs29EROCgSClp9ciaEaMaj9PFmCj7xtBGsrhJJQVPQiYy1pKHgC8pMFzFrkE+6nzC9h0q4bu+E/LxxhVEP02mbV32YDSkAu4chJu5goI5PLLEtZBI8eWuIDGeTneQdhsSeOBHy5cSpVyhimcVDj+SmkB4Ae4dNqO00mrUw0oiAiSfpWKEyxqWCcZBx2NVpGaQounpb9z3YahWeGFL6h8mHRlqrjmVNC6QTq7JL/OpOC76Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8cOmEz4bAoip01NyXlO78E+/4ASrr50huT+35obuxUIUigrQfpY93tX4o1Ge2dgXUlfz5eXNaerWTM0eweSiIyJt41aDHSw3tpUK7CqNjcZrmjm4yk/Lt/di0e28Cl0obNHoNd/Uz3J3hrhcUcG4Y4ocjME7xMD0+gb/4EeFNX58SAYd+fx7YSfCVVxFFQdlg4a2CniiFAXyAMNI0ExatpFY8dbAGthJrdosMfP3RLdgYUuigxiBkEYATu462PLd5TJHg0uMo+zRYau8nyRscmFQmk7aM309EcQr+Ja8XksOImbuXocDYNLnN166Ca+DDrKw206RA7AqrfY1Whgrw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 28 Nov 2025 08:51:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcX7qka++CFdufxEmRWlGEcHg6JrUHyH6A
- Thread-topic: [PATCH v2 1/2] xen/dom0less: move make_chosen_node() to common code
Hi Oleksii,
> On 27 Nov 2025, at 16:26, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> wrote:
>
> The current implementation of make_chosen_node() does not contain any
> architecture-specific logic. Therefore, move it from arch-specific
> files to common code.
>
> At this stage, there is no need to introduce an arch_make_chosen_node(),
> as no architecture-specific customization is required.
>
> This change avoids duplication and simplifies future maintenance for
> architectures like RISC-V and ARM.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
Changes looks good to me!
I’ve also run on arm64 and arm32 on FVP platform.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
