[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/24] xen/sysctl: replace CONFIG_SYSCTL with CONFIG_MGMT_HYPERCALLS
- To: Penny Zheng <Penny.Zheng@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Wed, 26 Nov 2025 01:02:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5tKIrGofXLPN6qgL4uafSzn5M401zlwadw+S5GDn4Pg=; b=iypFtjRJLPvwIU/5PfLb0XOEsgG/J58TfLf9eXMZRuXfarGxAez6cyMulK+jgNLKTaEu4XHr8IjGI2ZneRz2E3fozlTbYyDXZ3HLES7IhdAWZ76ooKN5zC9wxEirIpzOF1O0R8/0qgsBCqFS0Pp3tt5ufLPwT4sS4Wz1f7wOWyTO9KbalI/4Qpw83Rbp+LzKyw3DlBui1vv1gY43b2PoewRAM4h9UG3kYVSSD+M0viqMELR6zp/iBS7zp81deEjxqaa30/8b3p2Ef75KgNsDSN+//sEvScGGT+AUiydm2t62xlwLff/hJOsTFxoLWHLdz0MYFIcdvjwMCan0JxkVoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aXlFj44cUA0mQ+ZajI7yM2aOSLtTmSz1NUpxjDGUkt9eR2k9mcmXRCWHdOBLjxcC2gJ2uBCNAnOV7LF9BDeTrMdAL8+Zv1pBL/d9QsWpwBCojATgODlsk4tHc/+AD0udKSK/G9DdTK4t3g9Ut9NtSz/kHy/GCXyfdYpty+dFJQt+X12bXTIUtCMwKINLLpLb/g4ly57U/M1lDDnY3zRwv/xXsa1L+k00YXir41rXUy+PZJUg7tSUpwZJMxyE5a67YUGMLSHWV1bPfOb5G9qPF5smHUcJYoX0zb/Kys2HmjdXEiutYL78Vndp8kumMXjfmdi22krlROzCiM4xtbgndA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: ray.huang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Nathan Studer <nathan.studer@xxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>
- Delivery-date: Tue, 25 Nov 2025 23:02:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi
On 21.11.25 12:57, Penny Zheng wrote:
Rename all the CONFIG_SYSCTL into CONFIG_MGMT_HYPERCALLS to help provide a
single option to manage all unnecessary hypercalls, including
sysctl, domctl, etc, in dom0less system and PV shim mode, which could also
make it easier to support randconfigs.
While doing the replacement, we fix some bugs on xsm system:
- wrap the whole xsm function to avoid bringing unreachable codes when
MGMT_DOMCTL=n
- add missing wrapping in include/xsm/dummy.h
Suggested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Acked-by: Stewart Hildebrand <stewart@xxxxxxx> #ARINC 653
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Alistair Francis <alistair.francis@xxxxxxx>
---
v2 -> v3:
- wrap the whole xsm function
- add missing wrapping in include/xsm/dummy.h
- refine kconfig description
---
With below diff..
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 6709c3c95c53..f478adffff9c 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -652,9 +652,8 @@ menu "Supported hypercall interfaces"
visible if EXPERT
config MGMT_HYPERCALLS
- bool "Enable privileged hypercalls for system management"
depends on !PV_SHIM_EXCLUSIVE
- default y
+ def_bool y
help
This option shall only be disabled on some dom0less systems, or
PV shim on x86, to reduce Xen footprint via managing unnessary
It could be very helpful to consider this patch to be applied first.
- number of tags indicates that it's the way to move forward
- with above diff patch 4 can be dropped
- it is mechanical change, but it's big and constant source of
rebase/merge/cherry-pick conflicts
- once applied it will allow, actually, parallel development of this feature as
MGMT_HYPERCALLS will
be defined while build not broken.
--
Best regards,
-grygorii
|
