Re: [PATCH] libfdt: Replace hardcoded FDT version numbers with macros

[Julien Grall <julien@xxxxxxx>]

Hi,

On 13/11/2025 10:36, Dmytro Prokopchuk1 wrote:
> Replace all hardcoded FDT version numbers (such as 16 and 17, or 0x10 and 0x11)
> with the macros FDT_LAST_COMPATIBLE_VERSION and FDT_LAST_SUPPORTED_VERSION
> throughout the Xen device tree and libfdt code.
>
> This avoids magic numbers and makes the Xen codebase more robust to future FDT
> version changes.
> > Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
> ---
>   xen/common/device-tree/device-tree.c |  2 +-
>   xen/common/libfdt/fdt.c              |  8 +++++---
>   xen/common/libfdt/fdt_ro.c           | 13 +++++++------
>   xen/common/libfdt/fdt_rw.c           | 16 ++++++++--------
While I appreciate the goal, libfdt/ is meant to be a verbatim copy of 
the [1]. I would like to keep it like that (backports would be 
acceptable). So if you want to make any change, then it first needs to 
be merged in the upstream repo.
Cheers,

[1] https://github.com/dgibson/dtc/tree/main/libfdt

--
Julien Grall