[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21] symbols: avoid emitting "end" symbols for data items
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 29 Oct 2025 15:13:50 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z36N2mcgqN3bxF5mL+CWYHY7pIrD+GcGYUkwuIHCSDk=; b=WZ/eCWmIJmgRmlXkykiUYKxt+pV+l8d4wGWqCTGsaA4upnPKGW2beP1vRgW7rgesc1dzNFQBmx8i3NiokCmT2pnOBnp24l+66fe/wWigxkTvdten63L1nU6QlsBcf/9apI77/e3BDP/fYHtd0I9cKeXuw3W4/gLHRwyRN2F9ooDYyZPcmdwQBQe6309LnJukNzY2FZhrnxTkQui/kgWXbQu9xBKf2OnPp57/sl/JDOziNIjGXkanxY4M33o4ogUcebIka5OukEe2axRHfcqgAP8OGNhPqDR9QX85pMzgEhwfPlYfbU3Eek3rwn+xRr4Jyd1gS1hV0b8jzkz3UyUUnA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jFCBCyrLKXrqXFbRcIxBAvo0hcmPMFK/OVicwwIJgVQ+JitaHJxSFKX2axV92kn6zLZkIp+pax6FUBylVZcddYMezKdZ71qVPx+xrkeFVXo1n3GjxigDK4IbWK4/Jk3e+1K7Pdh/+KV3XQ5J2VYzGNvWM7MKMrn5Dl0XVkWk4ArIO+wIG+JRjnDg4qcrNSqArA4dx69KZSJ5rmuExHleg9ojYr3oXWiKqalFJ1cLWe19oCMUclrW38knfKjqiMFIlmv/uvdFSoEsVkpBpyhl954ftwwggP7AkukKIeGRrzfymIcdBCHIBno3ED3BIv89CoBnLuTDSFBye74GY7gu8Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 29 Oct 2025 15:14:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/10/2025 1:34 pm, Jan Beulich wrote:
> symbols-dummy.c and the generated .xen-syms.?.S may place their symbols in
> different sections: Like for all C files, -fdata-sections may be in effect
> there. As a result, besides moving these symbols may then also have
> different amounts of "end" symbols inserted between them.
Sorry, I can't parse this sentence. Do you mean "these symbols, there
may also be" ?
> While the
> movement is likely not problematic, the change in table size is - linking
> passes 2 and 3 want no address (and hence no size) changes between them.
>
> As, at least right now, the "end" symbols are useful only for code, limit
> their emission accordingly. When data symbols are emitted (i.e. when
> LIVEPATCH=y), this obviously also has a positive effect on overall table
> size (I'm seeing almost 600 entries going away in the build I'm looking
> at).
Xen-crashdump-analyser needs end in System.map, and I expect so does
`crash`.
As this patch only adjusts the embedded symbol table, I think that's all
fine?
~Andrew
|
