[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] xen: Support LLVM raw profile versions 5, 6, 7, 8, 9, and 10
- To: Saman Dehghan <samaan.dehghan@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 27 Oct 2025 22:36:06 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=haAV+wvS4mk1r1ap7TS3pbrS6p39qDKcSu0uQEHXbN4=; b=te1hNGoZXXedaB9Uay2ePb5xvWdDax8XIvaG5yC/J0/OoztQHt5Po6s7vlRb0OrLBr/SppRLB586gSC3ZsvlqD9oknR5xjIbOSjzGLd8UBJjnHAxFO8TMKOOVBH+vYof3LBrdt0mErXJJS0NSNaG+i9cEXfVTu7pmwI8itO6Zwl+c27wZNUohDZbu8SNReSsJgNCdTOjP6Rl8hKfux7ZHGzWPAPeZjvOU6TcI5xnOTlkj+cXu5mhwhqyT4IQFTOAGn02eQBUcaqdSinXlPKjIrsQZv26PjGRz2SP5c2OSjvxZucEtBLC3LvcXgo0QTHPnIO2xv7P/J6r4lTN61WowA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MTPSptDBq7T598GFRGJvbv7MuC61qmVOnEGSaLTMI5Vg1cG/fht6LDXvwFCIQKIi/tFV/CpNd0EO93wjUyI7UWY7xtVaB0PpRiEkbWNNQWiC/jB5lZN8cfYK0p9XJFpzK82r+hxHE+GYdelcNOgkdui0IBI/ytvxC4pcDBWLVuJpjE2YsZfV1DgFO5gU7fwzNa81tcsaI61THuofgDWl2SnwUDwqU8oSibupHsF1NiFMpsPMo7IFryyZTDZw2gNqY8xpMylBc9LlDWMaRTZ/vBDUJdmS13mS+6u+VRijTlVjpj9J3SIm1k2C8omegl9akP0XE8BODT++Ln4xE3wQGg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wentao Zhang <wentaoz5@xxxxxxxxxxxx>, Matthew L Weber <matthew.l.weber3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 27 Oct 2025 22:36:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27/10/2025 9:30 pm, Saman Dehghan wrote:
> This change enables compatibility for measuring code coverage
> with Clang versions 11 through 20 by supporting their respective raw
> profile formats.
>
> 1- Added support for LLVM raw profile versions 5, 6, 7, 8, 9, and 10.
> 2- Initialized llvm_profile_header for all versions based on llvm source
> code in compiler-rt/include/profile/InstrProfData.inc for each version.
> 3- We tested this patch for all Clang versions from 11 through 20
> on x86 platform.
> 4- Fixed linking warnings related to LLVM profile sections in x86.
>
>
> Signed-off-by: Saman Dehghan <samaan.dehghan@xxxxxxxxx>
> Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Tested-by: Wentao Zhang <wentaoz5@xxxxxxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Changes from v3 to v4:
> 1- Use LLVM_PROFILE_VERSION in preprocessor conditionals
> instead of __clang_major__.
> 2- Use DIV_ROUND_UP helper.
> 3- Remove unnecessary zero initialization inside struct.
> 4- Remove fallback macro definitions in linker script.
> Changes from v2 to v3:
> 1- Additionally support raw profile version 5, 6, 7 in clang 11, 12, 13.
> 2- Fix coverage related linking warnings in x86.
> 3- Revert unnecessary type changes, casting, etc.
> ---
Excellent. Thankyou. This all looks in order. I've committed it.
~Andrew
- References:
- [PATCH v3] Support LLVM raw profile versions 5, 6, 7, 8, 9, and 10
- [PATCH v4] xen: Support LLVM raw profile versions 5, 6, 7, 8, 9, and 10
|
