[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] misra: address Rule 11.3 for NextMemoryDescriptor macro
- To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 27 Oct 2025 21:13:38 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gcmCZIr32s3TT5kr9ozaZ8XBlM5npTBDs6uG5N73rsM=; b=KO10bsCtrc4Da21cqHiZk5bEQHAdlDhpTaiQo3kkYRLAhqpHaAOGAbABgJUsAhEdOe01dnNBAKWouMLHN4o/tSLTEDNtbzfJ2l274CjDJAMNTDdK6Tat8SVyp/F0y+aMnnFlN3szn0Yk6O71y0RM1lC0cnRTIHK9kIiETUGx6tAWjwPrUMmOt4NhZ29h0T+m4+ZCKazMdPPEC1itnl1Fnt/wS4JMpg22AbU8ATxIQnthKG6S0BavWJeyNGvnJ/CBTARDGXKLiYBkH3nv25RoB223fM1kHG4XlvPpXwf0cGD8FU9hN4GhoUGJCJZ8zS0f2GW08w2QwiUGSujSbntHTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XQRybI8wXl4d2GV86O9NiZoJsxOni3OR6l81hoXzC6L7Hb8wxSGvM89aJMxKl4JVMVj289iWtxqY1IozoDDHbU5O5xdZs9sbKV3beST00SDcRe6p7dWz9FnRJmcL0JOg/cAAXywD6m5xHSRQfYW/slDKt8nStfa/qG0EPo9/BqxHAgO2ZY5dvSKORRjX0LEF7ajoXCm3GTGyLtpIRT+fYSB6rt3EaEcbWEtabXpwAisvZOOVHmmU7l+MXpxCN/fAJW9+2LFh72O/VU2I5KOG8uDpaHBuA5MmT2RibP3f1q563Biypy3SGgv0qHcnKn52gnKMURi2Nl4g0lo5Jh0asQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 27 Oct 2025 21:13:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcREbgd161cNZLPEqc4+KUMk5T6LTQ6yIAgAQN1YCAALvbAIAAz76A
- Thread-topic: [PATCH] misra: address Rule 11.3 for NextMemoryDescriptor macro
On 10/27/25 10:50, Jan Beulich wrote:
> On 26.10.2025 22:37, Julien Grall wrote:
>> Hi Jan,
>>
>> On 24/10/2025 08:43, Jan Beulich wrote:
>>> On 23.10.2025 20:00, Dmytro Prokopchuk1 wrote:
>>>> --- a/xen/arch/arm/efi/efi-boot.h
>>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>>> @@ -227,6 +227,7 @@ static EFI_STATUS __init
>>>> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *
>>>> }
>>>> }
>>>> #endif
>>>> + /* SAF-15-safe casting a pointer */
>>>> desc_ptr = NextMemoryDescriptor(desc_ptr, desc_size);
>>>> }
>>>>
>>>
>>> While at present we have only one use site, needing per-use-site comments
>>> isn't very nice. Putting it into the imported header isn't nice either.
>>> Could Arm perhaps get away without using the macro, just like x86 manages
>>> to?
>>
>>
>> IIUC, you mean something like:
>>
>> EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;
>>
>> If so, this would work for me.
>
> Right, provided that efi_memmap is of type void * or const void *.
>
> Jan
Thank you for the advice. I'll prepare v2.
Dmytro.
|
