[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen: fix randconfig build problems after introducing SYSCTL


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
  • Date: Tue, 21 Oct 2025 21:39:47 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gARv+zKauoR8mczy6uZqExysIqSaoputsMuET04rR3s=; b=DkBl8bZhvuW7ULh6pr3oPW9OPQ3STLOtQwH7OOm3Q6T4DINr/AuVnKcP+mXTQ+CkvlUHLQZ3wYP/vtRKjuXwwbKkOWeS8SHgFIflg8wKW84vyfInWYG2otjJo9y+eOaMFufzxykc/BoQtqVtfeAkHjCzTSRSsbQlQLpLAXGlna18V7B2Gg+HlSSP8HOCH0rsSvl+TC8g+8ScAlzjWCAz5C1a/Ad9v4hNq6ekTbg54xj9kssRtq8Uk+VvkcdVRfKed2NZgx7AzjY4RyZlsPY2sCl7PIvwEbgLd0v1KrC8H3MNLelKZgKFSayrpbgjDzJoIVQF/uCISxskzTMiCAWHQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FgmmREDKCNNzM2Cdb2pGeuiXF3HHPJETW8AQKv+paSRl7gSclpLBJ26wYeMn/0/W+TAnsSTKR49hP9njg2udwLJGDYtiJTWRUtb+y4ZEJ8mxMcnWABs5qpME6ww+UZj+d1EbAgtClqScwwNLasaRxt0pB+dQKwLpWT5NW1Ia9qWBRqpULZaL3Qvnxsdzgv6SpBQSLGPPrtqRAKfHkry5QrTDQ4HZEr3yXN0HGUhIn0vVRRSha6Uj5uHIgPMh7RXXNuVxypt8ebL9aDvN28gOzs5DyJBJY83dUYuT9YJpV4k+fO0oH/mT9Sb6DpE8lT9777fLinGu2fvkWQSQ9hebGQ==
  • Cc: <sstabellini@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <roger.pau@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, <Penny.Zheng@xxxxxxx>
  • Delivery-date: Wed, 22 Oct 2025 04:40:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Fix a few randconfig build breakages that started appearing after the
SYSCTL patch series.

First, reintroduce depends on !PV_SHIM_EXCLUSIVE for HVM, as it was
before 568f806cba4c.

Also, add depends on !PV_SHIM_EXCLUSIVE for SYSCTL, that way the
behavior goes back to what it was before 34317c508294.

These two changes are individual reverts, going back to the behavior
before SYSCTL was introduced.

Finally, change SHADOW_PAGING so that it depends on !PV_SHIM_EXCLUSIVE.
That is because xen/arch/x86/mm/paging.c:paging_domctl has a dependency
on domctl.c and domctl.c is disabled by PV_SHIM_EXCLUSIVE.
Alternatively, we could add #ifndef CONFIG_PV_SHIM_EXCLUSIVE around
paging_domctl.

Fixes: 568f806cba4c ("xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE"")
Fixes: 34317c508294 ("xen/sysctl: wrap around sysctl hypercall")
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
CC: jbeulich@xxxxxxxx
CC: andrew.cooper3@xxxxxxxxxx
CC: roger.pau@xxxxxxxxxx
CC: Penny.Zheng@xxxxxxx
---
The new domctl series resolves the !PV_SHIM_EXCLUSIVE dependencies in a
clean and comprehensive way. As an example, the paging_domctl issue is
resolved by patch #3 and #5.
---
 xen/arch/x86/Kconfig     | 3 +--
 xen/arch/x86/hvm/Kconfig | 1 +
 xen/common/Kconfig       | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 3f0f3a0f3a..c2689a3f1c 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -144,8 +144,7 @@ config XEN_IBT
 
 config SHADOW_PAGING
        bool "Shadow Paging"
-       default !PV_SHIM_EXCLUSIVE
-       depends on PV || HVM
+       depends on (PV || HVM) && !PV_SHIM_EXCLUSIVE
        help
 
           Shadow paging is a software alternative to hardware paging support
diff --git a/xen/arch/x86/hvm/Kconfig b/xen/arch/x86/hvm/Kconfig
index 5cb9f29042..f10a2b3744 100644
--- a/xen/arch/x86/hvm/Kconfig
+++ b/xen/arch/x86/hvm/Kconfig
@@ -1,5 +1,6 @@
 menuconfig HVM
        bool "HVM support"
+       depends on !PV_SHIM_EXCLUSIVE
        default !PV_SHIM
        select COMPAT
        select IOREQ_SERVER
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 76f9ce705f..53f681bbb2 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -653,6 +653,7 @@ menu "Supported hypercall interfaces"
 
 config SYSCTL
        bool "Enable sysctl hypercall"
+       depends on !PV_SHIM_EXCLUSIVE
        default y
        help
          This option shall only be disabled on some dom0less systems, or
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.