[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21] tools/libxc: fix xc_physdev_map_pirq_msi() with PCI segments != 0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 20 Oct 2025 10:07:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fq3oPh2Gf2ty83ad98IjOROqdIgyjSf3rcrLzj4Fbu0=; b=y1bLDJOjoIcxwlDCULbVtZaP71fSyQwDywTDD89QLHO8xBCJjqRSBsKnY/5y8tOeS6THVF9agXpXFzxM/NBDcF1Xxwn81o/yJe4MgpeGVaxpawQUdm3jPGnR9fWqh+mmcsP/U2Mo+rHUCX7oQYrHycNCigMa/sMloWhBYu/sO6z2binGBZzf+x5vznFhnjow+LoZzCeBLJo5xZmKDQ4CiUctDhpvctAutb2sE6oAFPLzhJCnLD2tXb+/tyOgmYQTkNDzj4NTf5aBQJk3qqDUr+05wwBtOJZnqzobvQ2vYuzul4jc4mT62ikj1KJZW1sakjfTxPfhx+f7XB4KCMtnyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cx+HF7lHfx53jFGDakom7J4D1X5251ZWc0vIFNez0bEmsyBDWc23vJsnIF357lbxcW6dQgzSjBb+EArSrDexjfkBmNLP4ZLtLy8qaavjFUtLWzEickRlt94gA8Mt5Ma0ZN46QgraIqgpzVAUlQABGzygzGXy/PKgCbWVEGQwB9GYVScPo9WWtSNiAXyxldEc0LnX+r6v2EFw0Clb7KrClHwXYPEKxlwi8BZcQEpsoUtnlDy8PTN8hB/ZU2hWXAiqaa0I4Bli8scZpZObYbVaS9h3ZW+qjTe9L4idUhTT7w5JWNDO8lNWs3gmfGsGBJ8ljnbnqSLaZ9L6wOTGbSwJgg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: oleksii.kurochko@xxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 20 Oct 2025 09:07:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 20, 2025 at 09:46:42AM +0200, Jan Beulich wrote:
> On 17.10.2025 16:14, Roger Pau Monne wrote:
> > Otherwise it's not possible for device models to map IRQs of devices on
> > segments different than 0. Keep the same function prototype and pass the
> > segment in the high 16bits of the bus parameter, like it's done for the
> > hypercall itself.
>
> While easiest, that's an odd interface, though. Should, at the very least the
> function parameter then be named e.g. "segbus", along the lines of "devfn"?
I certainly don't mind using segbus instead of plain bus, will adjust
now.
> > Fixes: 7620c0cf9a4d ("PCI multi-seg: add new physdevop-s")
>
> This commit wasn't about tool stack uses of the interfaces at all.
But there should have been a tools side change somewhere to make use
of that interface, at the point that support for multi-segment was
added to Xen? Otherwise the support feels like half done.
Would you prefer me to use the "Amends:" tag? Or no tag at all.
Thanks, Roger.
|
