Re: [PATCH v7 08/16] emul/ns16x50: implement MCR/MSR registers

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.09.2025 08:00, Mykola Kvach wrote:
> On Tue, Sep 9, 2025 at 12:12 AM <dmukhin@xxxxxxx> wrote:
>> --- a/xen/common/emul/vuart/ns16x50.c
>> +++ b/xen/common/emul/vuart/ns16x50.c
>> @@ -107,7 +107,7 @@ static bool cf_check ns16x50_iir_check_thr(const struct 
>> vuart_ns16x50 *vdev)
>>
>>  static bool cf_check ns16x50_iir_check_msi(const struct vuart_ns16x50 *vdev)
>>  {
>> -    return false;
>> +    return vdev->regs[UART_MSR] & UART_MSR_CHANGE;
>>  }
>>
>>  /*
>> @@ -232,12 +232,63 @@ static int ns16x50_io_write8(
>>              regs[UART_LCR] = val;
>>              break;
>>
>> +        case UART_MCR: {
> 
> Probably the opening brace should be moved to the next line.
> See CODING_STYLE:
> 
> Braces ('{' and '}') are usually placed on a line of their own, except
> for:
> 
> - the do/while loop
> - the opening brace in definitions of enum, struct, and union
> - the opening brace in initializers
> - compound literals

strictly by the wording of the doc you're right, yet if you go look then
you'll see that we really permit both forms (and apparently prefer the
one used here).

Jan