Re: [PATCH v6 04/13] xen/arm: Don't release IRQs on suspend

[Julien Grall <julien@xxxxxxx>]

Hi Mykola,

On 01/09/2025 23:10, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> If we call disable_nonboot_cpus on ARM64 with system_state set
> to SYS_STATE_suspend, the following assertion will be triggered:
Looking at the stack trace, I don't understand why this error would not 
happen when offlining a CPU. Can you clarify?
Anyway, I am not very happy to special case suspend/resume in the IRQ 
code. So I would strongly prefer if we follow a different approach.
The one that come to my mind is to switch from request_irq() to 
setup_irq() and allocate the action in a per-cpu variable. With that, 
there should be no free happening with the stop_machine helper.
Cheers,

--
Julien Grall