[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/IO-APIC: drop io_apic_get_unique_id()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 9 Sep 2025 09:49:06 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xeeoystyVUbnYS2u183/jG+eMUB6+ooMWgEdXGHSN1I=; b=efoev2ukoTPob2kyeuGQc+CdfOvq33PMZEF3ig8Y/6+HBzg6TUgXxaSjzNXIjjc1DmPT4+hExLN3sBnboYc6BtTHpwIWn+O9ag6NBliSrU9j7UM+vrpxCPjsppJrmTcVAMWZtAG05vYHYxTX61Wf7mC/+HUBxnCVfRS0bhjy1kcK1XtPFH+9BcETlOZkEQE+SZu93gFyw1ANwLoqukKPbi+gi+cxI8ekrPAUjeIsEbThZbG/vWok1TUn77IqlisITopc7cfLNpzpKGAVJDrspxd3AnKeflrg+uSxYbwJvSp6H+/s0G4OZs3z8l8QILSGaLwONR7/e/BbPPPRw00hLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eAWfHIBTW/Z9di8PXNdUiB2nG3cEanApmDyW3tHo/nEzEjORlV99t1sUMR9C/MTW7R6JuyU2MDOv7E6g57U9dd3vzQqzRZeeKKu2jS9VI7jIqbO1n8FRtkAHxT1BCW2rZQ1FGDfW9FYoeClcTOQi9Qgn2MsSsUfd3YZWQBMWdR9DdFAIij+uC2MGnc30zFHNjw3MBl2U+1FP2uRnpP8EodyOGASy1Mc4vmJ4nbcPiJ1+AmbKmAoWSjUInzqtUMy8jbs4h+TeMsUkaQCbXDUwRLzVlr305Wj7TZXtnRLhbHIjR0apdfy0hv/5VbbsHwfUfJGt702YPa3PegARGFhwWw==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>
- Delivery-date: Tue, 09 Sep 2025 13:49:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-09-03 03:56, Jan Beulich wrote:
Along the lines of what b89f8f054f96 ("x86/apic: Drop sync_Arb_IDs()")
said, the function is dead logic as well: All 64-bit capable Intel systems
have (at least) xAPIC (if not x2APIC).
Even if Eclair can't know it, such code is violating Misra rule 2.2 (dead
code; we didn't accept that yet, but - where possible - we probably would
better follow it). Depending on one's reading, this code may actually be a
violation of rule 2.1 (unreachable), which we did accept:
"Code is unreachable if, ..., there is no combination of program inputs
that can cause it to be executed."
Otoh it's "only" __init code.
As this removes the last user of APIC_XAPIC(), remove the macro as well.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
