Re: [PATCH v17 0/4] xen/domain: domain ID allocation

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

This series is fully acked except for:

- a minimal change to xen/arch/x86/setup.c
- the self test tools/tests/domid/

Based on this, I plan to commit it in the next couple of days. Please
let me know if you have any thoughts on that.



On Fri, 29 Aug 2025, dmukhin@xxxxxxx wrote:
> Patch 1 introduces new domid_{alloc,free} calls.
> Patch 2 is a prep change for domain ID allocator test.
> Patch 3 introduces some basic testing for domain ID allocator.
> Patch 4 adjusts create_dom0() messages (use %pd).
> 
> Link to v16: 
> https://lore.kernel.org/xen-devel/20250812223024.2364749-1-dmukhin@xxxxxxxx/
> Link to CI: 
> https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2012378054
> 
> Denis Mukhin (4):
>   xen/domain: unify domain ID allocation
>   tools/include: move xc_bitops.h to xen-tools/bitops.h
>   tools/tests: introduce unit tests for domain ID allocator
>   xen/domain: update create_dom0() messages
> 
>  .../xen-tools/bitops.h}                       | 16 +++-
>  tools/libs/ctrl/xc_misc.c                     | 13 +--
>  tools/libs/guest/xg_dom_elfloader.c           |  1 -
>  tools/libs/guest/xg_dom_hvmloader.c           |  1 -
>  tools/libs/guest/xg_private.h                 |  2 +-
>  tools/libs/guest/xg_sr_common.h               |  2 -
>  tools/tests/Makefile                          |  1 +
>  tools/tests/domid/.gitignore                  |  2 +
>  tools/tests/domid/Makefile                    | 88 +++++++++++++++++
>  tools/tests/domid/harness.h                   | 54 +++++++++++
>  tools/tests/domid/test-domid.c                | 95 +++++++++++++++++++
>  xen/arch/arm/domain_build.c                   | 13 ++-
>  xen/arch/x86/setup.c                          | 11 ++-
>  xen/common/Makefile                           |  1 +
>  xen/common/device-tree/dom0less-build.c       | 15 +--
>  xen/common/domain.c                           |  2 +
>  xen/common/domctl.c                           | 43 ++-------
>  xen/common/domid.c                            | 95 +++++++++++++++++++
>  xen/include/xen/domain.h                      |  3 +
>  xen/lib/find-next-bit.c                       |  5 +
>  20 files changed, 397 insertions(+), 66 deletions(-)
>  rename tools/{libs/ctrl/xc_bitops.h => include/xen-tools/bitops.h} (84%)
>  create mode 100644 tools/tests/domid/.gitignore
>  create mode 100644 tools/tests/domid/Makefile
>  create mode 100644 tools/tests/domid/harness.h
>  create mode 100644 tools/tests/domid/test-domid.c
>  create mode 100644 xen/common/domid.c
> 
> -- 
> 2.51.0
>