[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v8 8/8] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC xen_sysctl_pm_op for amd-cppc driver
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Wed, 3 Sep 2025 03:14:28 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BAK7DeDIBY+h+qJnlFV1ONcfRP4n13DLZB6paRwZT9k=; b=X1DoNasP6LqHOYnlGRKx6EquvB3vHAd0bbCbG2H8Dxd1A41pendeFXLLCWraYZt4BX/3Tq1BFLh5CF6Lw8ynpvzat1Ul0E7rVSPhThEG7R0FdQgmTs45zP/BAwErcPVMWZjJSO1Iba12ryz6MqoyZh39IJDwhoEEm+gQNRESSP6mWczS7IXI3uCVzFhROvg/c/GFwrCq+QFKzD+ohkmnTqpwpNXxpZuXbKdpKK/6jR/L4OS5trFmbEUCgj9RNBOUmi6mpRmWzQdARFuYvMmCWFCAzH8XkqizSX/TI2q1nRg36jsuWcjjXxFqDtJFnpsxfU5r+KkNX4kexVLZaTpOGQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WxAwGY0JVmx1t9w6esGLnhpOJlKt/CE4IY60921/uYCzxfOzB7EJ58f3kRzMVjYn5TSkWYd2bmHSKpcmTS5pDiOG5s+XWosn+MUTvQk/gmTcABuvLovwMK07AKHk1Y7hb109/w3Szxv5iVYsKDmW4iqYs/bWK1oMdpSFNrRgO6fcx2UxbubaI2M3YKWxsxTcHfUs093TmZCioUrb9YEaALw+IXBBbgzSU33xU2Gtf98lid/iLjvpgDktH5zgQfGEDmnc4JJcl2Kxs5Ml3T/b9aAxFJst8u7NPVpDWl3hyPFCNnzu8zWoqxv1SY5DyI2/tMewPyRBM8UihmXK/kIJrA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Sep 2025 03:14:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-09-03T03:14:22.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcGANplGdEMGicVkezx0Fs9samVLR357kAgAjockA=
- Thread-topic: [PATCH v8 8/8] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC xen_sysctl_pm_op for amd-cppc driver
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, August 28, 2025 7:07 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Anthony PERARD
> <anthony.perard@xxxxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>;
> Roger Pau Monné <roger.pau@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v8 8/8] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC
> xen_sysctl_pm_op for amd-cppc driver
>
> On 28.08.2025 12:06, Penny Zheng wrote:
> > @@ -154,6 +156,17 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op
> *op)
> > else
> > strlcpy(op->u.get_para.scaling_driver, "Unknown",
> > CPUFREQ_NAME_LEN);
> >
> > + /*
> > + * In CPPC active mode, we are borrowing governor field to indicate
> > + * policy info.
> > + */
> > + if ( policy->governor->name[0] )
> > + strlcpy(op->u.get_para.u.s.scaling_governor,
> > + policy->governor->name, CPUFREQ_NAME_LEN);
> > + else
> > + strlcpy(op->u.get_para.u.s.scaling_governor, "Unknown",
> > + CPUFREQ_NAME_LEN);
>
> Isn't pulling this ...
>
> > if ( !cpufreq_is_governorless(op->cpuid) )
> > {
> > if ( !(scaling_available_governors =
>
> ... out of this if()'s body going to affect HWP? It's not clear to me whether
> that would
> be entirely benign.
>
HWP has its own unique "hwp" governor. So, imo, it may not affect.
> Jan
|
