Re: [PATCH v11] xen/console: introduce domain_console struct

[dmukhin@xxxxxxx]

On Fri, Aug 29, 2025 at 03:06:27PM -0700, Stefano Stabellini wrote:
> On Thu, 7 Aug 2025, dmkhn@xxxxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx> 
> > 
> > Introduce domain_console for grouping data structures used for integrating
> > domain's diagnostic console with Xen's console driver.
> > 
> > Group all pbuf-related data structures under domain_console. Rename the 
> > moved
> > fields to plain .buf, .idx and .lock names, since all uses of the fields are
> > touched.
> > 
> > Ensure accesses to domain_console pointer are valid in 
> > console_switch_input().
> > 
> > Bump the domain console buffer allocation size to 256. No extra symbol for 
> > the
> > value since it is used only once during data structure declaration. All size
> > checks use ARRAY_SIZE().
> > 
> > Allocate domain_console from the heap so that the parent domain struct size
> > stays below PAGE_SIZE boundary to account for more console-related fields
> > added in the future.
> > 
> > Finally, update the domain_console allocation and initialization code. Make
> > sure domain_console is not allocated for system domains.
> > 
> > No functional change.
> > 
> > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Thank you