[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned.



On Fri, Aug 29, 2025 at 09:56:27AM +0100, Mark Syms wrote:
> Previously this said it would only happen on barrier writes. Except
> the documentation blocks for
>  * feature-flush-cache
>  * feature-discard

I cannot parse what "documentation blocks" means in this context.  I
would maybe write this as:

"Previously this said it would only happen on barrier writes.  However
Linux blkback and possibly other backends already return it when the
type of the requests is unknown.

Fix the comment to clarify the return code can be used as a reply to
any request types not understood by the backend, not just barrier
writes."

> 
> Also say that they can return this error.
> 
> Signed-off-by: Mark Syms <mark.syms@xxxxxxxxx>

Possibly with the commit message adjusted:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.