[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] xen/vpci: purge BAR rangeset contents before use
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Fri, 15 Aug 2025 14:09:09 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YV5AM1xXJg5EuOpbatI/2a/CMhM/mA9PACHTI4d2Jko=; b=xc+65O/fRkMyk7L9itWUBauSThhTJxbyHfqbm2GQYVTegi3YiJ/YPn6EASHpWVXmxn8KDgHRl0mlYJJTmcHX1Ae5LNttDbtYJX1jjNoQa929uIdOW1CjMHiTBKo7Dax6p8Xzj/sVZOu8KGvCzJBla9CnQkWcZiNVku379TVxvcyx4w4nZaFageHyZ74uRYmyMCCgEwBJ0Ji8hh5UOSUuIiTs57KLs8jaa0gFIap4k75mSSJ28wUk7QFxIp4XZF3D9ENXZvFozsVx6RnfNWyeAOyvK9TFyiKPaUwzJo+kMx/et59USy0lN8AMqprXVtDyH1o8RhjN+5rN1G8w0muE7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j1chYo5XoRQRHoKg/T5sYomntK2fuyrsbrxVBawn7d3kGEbsbii45FA3VJjh5ypEbZfwYdw7u1no0EwYe+B3XQwzmSJjmc4MYSp+s1gIS4WC+rqd+XyDLveJLMlK7K+IjJc9QDAhRX2bZDaQwxsfiiHYfa4PJQmCFUnU2djKcnWNmheLVrqmgjS8MEyf85pbI3ZiUmyajT4Wkqrs8ARoaor9FWHN9I0y5iBBntc+POro7XF7OoLJmVifXfOHDwz7FUQmHcr5uGuAOtninApiCbtHqaO0gDyWUWuTylH6SMvoDa0LXdGzM/C1N572IgFwHHp1NkeOg9rVGPuzcnV1yg==
- Cc: <Jiqian.Chen@xxxxxxx>, <jbeulich@xxxxxxxx>
- Delivery-date: Fri, 15 Aug 2025 18:09:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/14/25 12:03, Roger Pau Monne wrote:
> It's possible for the BAR rangeset to contain stale data when used in
> modify_bars() if previous calls to modify_bars() resulted in errors.
>
> Fix by always purging the rangeset before usage, thus getting rid of any
> previous stale data. Remove the ASSERT that checked whether the rangeset
> was empty, it was incorrect.
>
> Fixes: 52ebde3cfae2 ('vpci/header: program p2m with guest BAR view')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
|
