[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/22] x86: FRED enumerations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Thu, 14 Aug 2025 22:18:56 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1755202736; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=J0M3XxeIUeWOBUmBkuPSheRSMFm4wMPEVIu+y0iS+ak=; b=cWj7kkMBPvg0n4RjCGgJavwi09c52lClqZOEeCkSyUsYnZYOParaE5i+cikfz07p0S0Y aXKzWiKleLVqOeyMzWZkqnox/qrso0OAeXEhElTS1i/H2132wsNvRnuivVIFs4nOXv7YO 5zlp3FwcuYtjeaXksXmNgxTdl8XNbOVVhDtMdDHybIioQoGnRJmnISZCvpT5/m1Sf7GmY 5xoiTkLK4VY2QSB5mQ9xgxf+aiNGKe0v1HOhofwKcDCZpDvfTnsjGo9EWlfIN2DcexT7E f1Cjcu+sfgVqsXIzM2HfEgIKjLz3YAoWxPAsGD6TNekRx9rRMcQ5Yw+zQAa/dmIGV7LAI db+3B2vKkUcAk+kXahkVeJnnIKluU86j8R5pdavJRTvJquigpYTvbfjxdUOoRi993CSce KYb+CqOPy4uHTRGOMqrsdMo5sDHx0NLrpUEv2RNH67of28aDvx5SN3AbUiREkHhA1ywc2 Dq60xlxQjwlkzFYl3AifqQzwaNxrkoxilQoA+2pljM4OGg+y/xa6OzdBm82ahqPD2xH5a lmLzKR0ZDlc623Qd4/ExjKDAr/y58sBNYOk2PaYU+0mNo3eb9ljgnrdwtacn9JFypF5FF vdOfRWLRGNVYBJTVAN+Xjkkxh4NwWC+xh/9gc50XReKXEeV5Agrix0eOE3rl0eU=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1755202736; b=pc0wvpGc8W71vHRjr5lZWV0niM88fe/Rx5H/xCsYU5FhMC7ve+mrzUeQt/t1JwOU5XKd m0f2GFeutDvjxKZCAlHRZ+2AGn3oUCwSHHA+/0JHcatuz6gG+M4nCKJHZr5OCeYKO3lPv 39jczqac1M3BWoD0iwBf2aos1JL0mXDudXjVAlymUVI8WtCc1V+RGUZ+Z7u9XYNooOgs5 X9D4NZBvUwpm8WTwgVkRoVGiu8fM8AOzA3oBiWd18jnakQIObfIfYUMGeHy3pbEDvqTJG 2h9d+WN3J8nJE91h15WWFZ4bFqb/BJEyGNAlfMEHzksbMz3F0HOfy5CamRxie/ePd0r80 xXMDBJJML9Kypcutl9rrR1mcm85AtCpuhEsOeRNFFOFAFvRGvkJtnAMpcn8I7ChjMZftZ YkdtT0538QB+Vx1m5wEdw2OgPJs3thZj1Juaa+bE7t0ViKcivyJtxNNsOpEi4/wOF6os5 OQQT/PEbFDr5j5t0qG5ocauhQROpqE6FE1QqOFeEt3NN3S25Mh+vacO0xvrLTLj7YIz60 Gb8WVJNz5nSj+c7PM9quxY9WuvZ77seCF54FRA59QA2jeyuoziexuTx7yC525jWoq32v2 laNeN/uq2dtAckRf0cU9egVUkJ30NijTKOkYjoZl8BnA74dOadUoHZ9QNM1dBd0=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Aug 2025 20:19:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-08-14 21:37, Nicola Vetrini wrote:
On 2025-08-14 13:47, Andrew Cooper wrote:
On 14/08/2025 12:44 pm, Jan Beulich wrote:
On 14.08.2025 13:42, Andrew Cooper wrote:
On 14/08/2025 12:20 pm, Jan Beulich wrote:
On 08.08.2025 22:23, Andrew Cooper wrote:
--- a/xen/arch/x86/include/asm/x86-defns.h
+++ b/xen/arch/x86/include/asm/x86-defns.h
@@ -75,6 +75,7 @@
#define X86_CR4_PKE 0x00400000 /* enable PKE */
#define X86_CR4_CET 0x00800000 /* Control-flow Enforcement
Technology */
#define X86_CR4_PKS 0x01000000 /* Protection Key
Supervisor */
+#define X86_CR4_FRED 0x100000000 /* Fast Return and Event
Delivery */
... a UL suffix added here for Misra.
I was surprised, but Eclair is entirely fine with this.
And there is a use of the identifier in a monitored C file?
Yes. traps-setup.c which definitely has not been added to an
exclusion
list.
Might look into it before the end of the week, if time allows. Is [1]
the right branch to look at?
[1]
https://gitlab.com/xen-project/hardware/xen-staging/-/commits/andrew/fred
Actually thinking about it, this is indeed represented in a signed type
in x86: according to the standard it's just a signed long [2], therefore
the rule does not apply. Then you would have a R10 violation due to the
conversion at the callsite. I would put a U regardless, since the
intention was clearly to have an unsigned long.
[2] https://godbolt.org/z/rT5j4j9vj
~Andrew
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
