Re: [XEN PATCH 04/11] tools/configure: Introduce deps on json-c lib for libxl

[Anthony PERARD <anthony@xxxxxxxxxxxxxx>]

On Mon, Aug 11, 2025 at 11:48:19AM +0100, Andrew Cooper wrote:
> On 08/08/2025 3:55 pm, Anthony PERARD wrote:
> >  xl: $(XL_OBJS)
> > -   $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) 
> > $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) -lyajl 
> > $(APPEND_LDFLAGS)
> > +   $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) 
> > $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) 
> > $(YAJL_LIBS) $(LIBJSONC_LIBS) $(APPEND_LDFLAGS)
> >  
> >  .PHONY: install
> >  install: all
> 
> Specifying both isn't entirely great when one is supposed to be empty.
> 
> Could we not have XEN_JSON_LIB(s) which is set to either $YAJL_LIBS or
> $LIBJSONC_LIBS as appropriate?

Yes, that sounds good.

Thanks,

-- 
Anthony PERARD