[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] BCM2711 reboot fix



Sorry, this is quite a rare experience for me. I'll prepare a new submission in a separate thread. Thanks

Evgeny

On 12.08.2025 01:22, Julien Grall wrote:
Hi Evgeny,

(Top-posting because this is related to the process)

Thank you for sending a new version of the patch. I am having trouble to apply this patch properly using "b4". It seems to add more content in the git log. E.g.:

    Message-ID: <0057d145ddd90c01922636205484088c02a0e45a.1748380800.git.megabotva@xxxxxxxxx>
    From: Evgeny Beysembaev <evgeny@xxxxxxxxxxxxxxxx>
    Date: Tue, 27 May 2025 13:48:31 +0200
    Subject: [PATCH] BCM2711 reboot fix

Looking at the content of the e-mail in more details, I see you posted the new version as a reply to the previous patch. So it contains some part of the previous answer. Patches submission should be on their own email (ideally in a new thread) with the subject contain the tag [PATCH v<N>] where <N> is the revision ID (in your case it should be two).


On 03/08/2025 21:16, Evgeny Beysembaev wrote:
According to the commit b334c1afad17 ("ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node") in Linux kernel, the `compatible` string for the watchdog peripheral in the DTS has been modified from `brcm,bcm2835-pm` to `brcm,bcm2711-pm`, which caused `rpi4_map_watchdog()` function to fail,
leading to inability to reboot the system under Xen hypervisor.

On my e-mail client, the lines will be wrapped. But when applied, you have some lines well over 72 characters. Please re-wrapped the commit message.

For more details how to submit a patch, I would suggest to read:

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

Patch diff itself looks good to me.

Cheers,





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.