[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] misra: add missing noreturn attribute for __div0()
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Tue, 12 Aug 2025 17:49:35 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1755013775; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=92+Xp9/ptUrRMK/PBNThr9/1s4fDv2zdvs5B2CKPtRA=; b=29/csnUI1hrs16f3AM4yA0Kr5Ry5KfCJH65kVFjs4iHADO9N5on1GYdIJZYPe4lrPk/P BTyieFwoF0TRmR+66P3HT+QeP/x7YstqjI7BrNI+0pHOLAPMZB38RLYKjB0tkX27eatWK f0LE93D/fdvdahlrLXm1YsJ7ScvsdPGd8oO5RwlOiW/hI8rYQwHWmYq7JsYJrs2pvgJZY aZouD1SRKwMC0gIWyYCkXStcMilVTj/zxzjKL+2dUn3mtbf7Jo0M/0HDfdBi6c3lDduxN +WFj8i4mEsUEjIMzxk9j7auqDQrFVhafXLasG1pNGde/CtbGoL1OWpwMPDJMuVhYqHTUG ZbwbZ/Onuq+nZAB2RvnqTlPuFkezXSeBTe8IEwIon+Is1gmRMS7DO4zE66D3KKIY9Gh2U U89WJqAAeYW3FKRSagtDQ7aEPung2HaO6UfUVLkm4FZIS1oTxPW+luH/+fQUpKXR5eQxd rVTSC7MJWOHHmssTMgkeVp67Zc75/yqE7DXVvPNtg/HxyxRzuKbAIcr/oliJZXz4O3s91 NoJAGRtGcg1OSNevG2MdYfSwI8w4QWYHw26Rxc7s1T5Dp6KRSiFIUL6X0ZJbYpD/LR99N zlhj3p5fMd7RqsWRbRUwudq4fRzr9BSICrMCZfa5PpAMf3XWUsOM7eQOUJjZcME=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1755013775; b=hWsy1XXb+IhtjyVtI094BmKpY6oX7bfBLwMxJhWcRnY6xvC/fhHjurNYhc1vUzX0cUeH CjJwRKRaDusWP0rz6B8KSGn+oRmS5nY+aCQpaj98je5w3NNM+ontAFx58oqchesEoQ/WD vQ8BMX1n2CyhVrwY0q06F+Fu3qsq1MahfOaovx69Fl0iHA8P7G3X+XyQ82mXJwkU0QB2E dndiCKZoJBMRy/inwbbgKDeNYKGYbxkgWK8cfHA6dmF6VOsY8+luYnmkn/XndhUCze3kp bRmoQeyAPrMlLhVmYJCxQaCbWZXV3gb2xqoFI8YnBc6MEJ5tIh3bQHwsyVrEdEWX4CK12 UdBCcVh0xUrb95a0DuEVEEAroBfaTZGvSUgF/Xe1Dy5+GsaXCHSzBt4OshS+2/W/DZ4Si BngneFnHgp/l1nEhsyZmeUGOMW5oH6f1zwLW9P2+C9ZCfigERpoKscBW+2xl/7qDnKxWM Os3i13sZB784xWHCmzjGw4lBxwqewfSr4xMTrzOB5zCPYJt17ndy4Q7aZ/4HgZgShTRPX h2C9HjCuQTd5BFpXB/uTYarjAkcgF0nMLDmS/at7YMbDSw+xlQFtDmjw81zseBLgQm0Lm PXyNPAVtIAHQ31q0OHRDwyEjEVUMNdhluRD3z6WlqSIhhlKspzU1ystGM16t9KM=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 12 Aug 2025 15:49:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-08-12 17:46, Dmytro Prokopchuk1 wrote:
The __div0() function never returns to its caller, causing a violation
of MISRA C Rule 2.1: "A project shall not contain unreachable code".
Add the `noreturn` attribute to fix this.
I was convinced that this was already upstream, as I made a patch a
while ago, but evidently I forgot to send it.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
Test CI pipeline:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/1980129839
---
xen/arch/arm/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 445e7378dd..2bc3e1df04 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -172,7 +172,7 @@ void init_traps(void)
isb();
}
-void asmlinkage __div0(void)
+void asmlinkage noreturn __div0(void)
{
printk("Division by zero in hypervisor.\n");
BUG();
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
