[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/8] emul/vuart: introduce framework for UART emulators
- To: dmkhn@xxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 12 Aug 2025 08:52:18 +0200
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 12 Aug 2025 06:52:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2025 01:55, dmkhn@xxxxxxxxx wrote:
> On Mon, Aug 11, 2025 at 09:34:58AM +0200, Jan Beulich wrote:
>> On 09.08.2025 20:55, dmkhn@xxxxxxxxx wrote:
>>> On Mon, Aug 04, 2025 at 12:11:03PM +0200, Jan Beulich wrote:
>>>> On 31.07.2025 21:21, dmkhn@xxxxxxxxx wrote:
>>>>> @@ -354,6 +355,8 @@ static void cf_check dump_domains(unsigned char key)
>>>>> v->periodic_period / 1000000);
>>>>> }
>>>>> }
>>>>> +
>>>>> + vuart_dump_state(d);
>>>>
>>>> How verbose is this going to get?
>>>
>>> Looks something like this:
>>> ```
>>> (XEN) [ 88.334893] 'q' pressed -> dumping domain info (now = 88334828303)
>>> [..]
>>> (XEN) [ 88.335673] Virtual ns16550 (COM2) I/O port 0x02f8 IRQ#3 owner d0
>>> (XEN) [ 88.335681] RX FIFO size 1024 in_prod 258 in_cons 258 used 0
>>> (XEN) [ 88.335689] TX FIFO size 2048 out_prod 15 out_cons 0 used 15
>>> (XEN) [ 88.335696] 00 RBR 02 THR 6f DLL 01 DLM 00
>>> (XEN) [ 88.335703] 01 IER 05
>>> (XEN) [ 88.335709] 02 FCR 81 IIR c1
>>> (XEN) [ 88.335715] 03 LCR 13
>>> (XEN) [ 88.335720] 04 MCR 0b
>>> (XEN) [ 88.335726] 05 LSR 60
>>> (XEN) [ 88.335731] 06 MSR b0
>>> (XEN) [ 88.335736] 07 SCR 00
>>>
>>> ```
>>
>> Definitely too much (for my taste) to put under 'q'.
>
> I'll try to limit the number of printed lines; register dump can be made
> compact for sure.
Yet even then I'm inclined to say that device specific data simply doesn't
belong here.
Jan
|
