Re: [PATCH v4 5/8] emul/vuart-ns16550: introduce NS16550-compatible UART emulator (x86)

[dmkhn@xxxxxxxxx]

On Mon, Aug 11, 2025 at 09:39:42AM +0200, Jan Beulich wrote:
> On 09.08.2025 20:37, dmkhn@xxxxxxxxx wrote:
> > On Mon, Aug 04, 2025 at 12:53:36PM +0200, Jan Beulich wrote:
> >> On 31.07.2025 21:22, dmkhn@xxxxxxxxx wrote:
> >>> --- a/xen/common/emul/vuart/Makefile
> >>> +++ b/xen/common/emul/vuart/Makefile
> >>> @@ -1 +1,2 @@
> >>>  obj-$(CONFIG_HAS_VUART) += vuart.o
> >>> +obj-$(CONFIG_VUART_NS16550) += vuart-ns16550.o
> >>
> >> I don't think files in this directory need a vuart- name prefix.
> >
> > Ack.
> >
> > Hmm, there's already ns16550.c which is UART driver, so it may be confusing 
> > to
> > have two ns16550s (although in different directories).
> >
> > I do not have a strong preference on the naming here.
> 
> We have several examples of files with the same name in distinct directories.
> As an aside - is it really only 16550-s that you emulate? Otherwise the name
> may want to be e.g. ns16x50.c or ns8250.c.

I'll use ns16x50.c.

> 
> Jan