Re: [PATCH v15 3/4] tools/tests: introduce unit tests for domain ID allocator

[dmkhn@xxxxxxxxx]

On Mon, Aug 11, 2025 at 09:58:24AM +0200, Jan Beulich wrote:
> On 09.08.2025 19:08, dmkhn@xxxxxxxxx wrote:
> > diff --git a/tools/tests/domid/include/xen/domain.h 
> > b/tools/tests/domid/include/xen/domain.h
> > new file mode 120000
> > index 000000000000..2eda9aed088e
> > --- /dev/null
> > +++ b/tools/tests/domid/include/xen/domain.h
> > @@ -0,0 +1 @@
> > +../../harness.h
> > \ No newline at end of file
> 
> In the tests we generally generate symlinks as necessary, rather than having 
> them be
> present in git. Furthermore it's not quite clear why a file of this name is 
> needed
> in a test harness anyway. Elsewhere we adjust hypervisor sources to make 
> respective
> #include-s conditional.

I'll fix the makefile for the test so dependencies are resolved on the fly
and no need for code adjustment.

> 
> Jan