[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] misra: comment default case in single-clause switch


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Mon, 11 Aug 2025 17:36:52 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yNqFeLEcTWrPGlajBVbJB109KX7ojmBgbcImzAPEgN8=; b=GE+aN97IKFbd6L1EUtOQmqwuekOm4ny0jaCDnJoy/jC8ESQ4HEBRyM0iLpjRcDkE7DQsP7U3eO29/O9tP/CpqAedEAzA1ljdNUEA7ppMw63RE7mzg6ZNRAG2X4++kVqzClOgQEF8DC4uzLvtm73fXj0IlrXV2z3taJ2S7QKB6LyFTvL+n3FoUHhpxxJqu+fLmHmXMdRMpaADXSUfAi1wPVZ6HsSOR7hHA+XNBJ3j3j9LRDBF39nVl9X0GNKw7djkpwC368GkztkfFlcaYh95z+TLSZdDWv4ReT8KW0Zqu013gaygHFUQAWUgCd0/NALRxvOb4+u2GQr3Z8nK+B0oqQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MXEu3O7p4oHTEVS3aM701ZCZKUFt3Pr09nJwuFq0ru40kCULv5MW/KosTyGDjlqmFIo0xEv5YU+6ZmyOmkdJ+NydB/VuqdQF4j/LJasCtIKnA/Lp0F8J/ZFsvpAXK+FI4IcBXsA/AS35MfT8wgMVLqasaFySFzus8jyKuoDCJ40+kPYToiLEhoaiHKgtwwR5Vi69BnCUPNCqqTL6e96pilhgWe+iKb0wDLdbNr0QCoPwzTSTeN/8oQk+l+McM5BHH2+HCJsYtkmoRwbS8UcJ6mUFlSEw9DfHLZRA77dKWg/ps4Jxfy90AnAG/3uZejFrMYMriga2UPVUByAlTPWS2A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Mon, 11 Aug 2025 17:36:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcCuaGmRofUvvSEEWe+78HEkEpWw==
  • Thread-topic: [PATCH] misra: comment default case in single-clause switch

MISRA Rule 16.4: Every switch statement shall have a default label. The
default clause must contain either a statement or a comment prior to its
terminating break statement.

This change adds comments in default cases in single-clause switches to
avoid violations of the rule where the `default` clause lacks a suitable
comment or statement.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
 xen/arch/arm/cpuerrata.c | 5 +++++
 xen/arch/arm/gic.c       | 6 ++++++
 xen/arch/arm/mmu/p2m.c   | 6 ++++++
 xen/arch/arm/time.c      | 6 ++++++
 xen/common/kexec.c       | 6 ++++++
 5 files changed, 29 insertions(+)

diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index 17cf134f1b..e31c72694b 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -735,6 +735,11 @@ static int cpu_errata_callback(struct notifier_block *nfb,
         rc = enable_nonboot_cpu_caps(arm_errata);
         break;
     default:
+        /*
+         * Default case left empty as other notifier actions do not require 
handling here.
+         * The single CPU_STARTING action in the switch is sufficient because 
this function
+         * specifically handles enabling errata workarounds during CPU startup.
+         */
         break;
     }
 
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index e80fe0ca24..dfbb0dfe08 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -436,6 +436,12 @@ static int cpu_gic_callback(struct notifier_block *nfb,
         release_irq(gic_hw_ops->info->maintenance_irq, NULL);
         break;
     default:
+        /*
+         * Default case left empty as other notifier actions do not require 
handling here.
+         * The CPU_DYING action specifically handles releasing resources 
acquired by
+         * init_maintenance_interrupt(), when the CPU is being taken offline. 
Other CPU
+         * actions do not require GIC-specific handling.
+         */
         break;
     }
 
diff --git a/xen/arch/arm/mmu/p2m.c b/xen/arch/arm/mmu/p2m.c
index 51abf3504f..d1f0ae0226 100644
--- a/xen/arch/arm/mmu/p2m.c
+++ b/xen/arch/arm/mmu/p2m.c
@@ -1828,6 +1828,12 @@ static int cpu_virt_paging_callback(struct 
notifier_block *nfb,
         setup_virt_paging_one(NULL);
         break;
     default:
+        /*
+         * Default case left empty as other notifier actions do not require 
handling here.
+         * The CPU_STARTING action is specifically handled because this 
function sets up
+         * virtual paging for CPUs, particularly for non-boot CPUs during 
hotplug. Other
+         * actions do not involve virtual paging setup.
+         */
         break;
     }
 
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index e74d30d258..4776110d97 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -382,6 +382,12 @@ static int cpu_time_callback(struct notifier_block *nfb,
         deinit_timer_interrupt();
         break;
     default:
+        /*
+         * Default case left empty as other notifier actions do not require 
handling here.
+         * The CPU_DYING action is specifically handled to revert actions done 
in
+         * init_timer_interrupt() and properly disable timer interrupts on the 
CPU being
+         * taken offline. Other actions do not involve timer deinitialization.
+         */
         break;
     }
 
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 84fe8c3597..0f78087a4a 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -549,6 +549,12 @@ static int cf_check cpu_callback(
         kexec_init_cpu_notes(cpu);
         break;
     default:
+        /*
+         * Default case left empty as other notifier actions do not require 
handling here.
+         * The CPU_UP_PREPARE action is specifically handled to allocate crash 
note buffers
+         * for a newly onlined CPU. Other actions do not pertain to crash note 
allocation
+         * or memory preservation for kexec.
+         */
         break;
     }
     return NOTIFY_DONE;
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.